Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WX-1626 Docker soft links #6741

Merged
merged 2 commits into from
May 10, 2024
Merged

WX-1626 Docker soft links #6741

merged 2 commits into from
May 10, 2024

Conversation

kshakir
Copy link
Contributor

@kshakir kshakir commented Apr 25, 2022

No description provided.

@kshakir kshakir force-pushed the ks_docker_soft_link branch from 5d15274 to e4fac8a Compare May 10, 2024 18:26
@kshakir kshakir changed the base branch from ks_slurm_singularity to develop May 10, 2024 18:28
@kshakir kshakir requested a review from a team as a code owner May 10, 2024 18:28
@kshakir kshakir force-pushed the ks_docker_soft_link branch from e4fac8a to d341b0f Compare May 10, 2024 18:32
@aednichols aednichols changed the title Docker soft links CROM-2620 Docker soft links May 10, 2024
@aednichols aednichols changed the title CROM-2620 Docker soft links WX-1626 Docker soft links May 10, 2024
@aednichols
Copy link
Collaborator

@kshakir I migrated the old CROM-2620 ticket to our new Jira project, you should be good to merge once tests finish.

@aednichols
Copy link
Collaborator

Could use a CHANGELOG.md entry too, IMO.

@kshakir kshakir merged commit 430fc40 into develop May 10, 2024
34 checks passed
@kshakir kshakir deleted the ks_docker_soft_link branch May 10, 2024 22:06
@kshakir kshakir restored the ks_docker_soft_link branch May 10, 2024 22:06
@kshakir kshakir deleted the ks_docker_soft_link branch May 10, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgainerdewar jgainerdewar jgainerdewar approved these changes

@aednichols aednichols aednichols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kshakir @aednichols @jgainerdewar