Fix warning on startup [no JIRA] #5570
Conversation
| @@ -251,7 +251,7 @@ case class WorkflowExecutionActor(params: WorkflowExecutionActorParams) | |||
| // - The job lasted too long (eg PAPI 6 day timeout) | |||
| // Treat it like any other non-retryable failure: | |||
| case Event(JobAbortedResponse(jobKey), stateData) => | |||
| val cause = new Exception("The job was aborted from outside Cromwell") | |||
| val cause = new Exception(s"The compute backend terminated the job. Likely reasons are preemption, running out of disk or memory on the compute instance, or exceeding the backend's maximum job duration.") | |||
There was a problem hiding this comment.
TOLish I wonder if someone has scripts targeting the current value of this message...
| @@ -251,7 +251,7 @@ case class WorkflowExecutionActor(params: WorkflowExecutionActorParams) | |||
| // - The job lasted too long (eg PAPI 6 day timeout) | |||
| // Treat it like any other non-retryable failure: | |||
| case Event(JobAbortedResponse(jobKey), stateData) => | |||
| val cause = new Exception("The job was aborted from outside Cromwell") | |||
| val cause = new Exception(s"The compute backend terminated the job. Likely reasons are preemption, running out of disk or memory on the compute instance, or exceeding the backend's maximum job duration.") | |||
There was a problem hiding this comment.
In HPC environments (or PAPI I suppose if they know the API calls to make), it can also indicate the user stopping their own job manually.
Not sure that's worth calling out as a separate case though, since in those situations they'd presumably know about it...
|
Re-requesting reviews because I introduced another stowaway in the changelog |
| ### Google Library Upgrade [(#5565)](https://github.com/broadinstitute/cromwell/pull/5565) | ||
|
|
||
| Previous versions of Cromwell use Google libraries that have been deprecated and will [stop working in August 2020](https://developers.googleblog.com/2018/03/discontinuing-support-for-json-rpc-and.html). This release adopts updated libraries to ensure continued smooth operation. No user action is required aside from upgrading Cromwell. | ||
|
|
There was a problem hiding this comment.
TOL so we may need to backport these upgrades into Cromwell 0.12 if the global endpoints really are shut down in August...
There was a problem hiding this comment.
If you check out 51_hotfix and navigate to BatchRequest.java:98 it specifically uses https://www.googleapis.com/batch.
In the execute() function at BatchRequest.java:216 the value of batchUrl is used unmodified and we definitely don't call the setBatchUrl() mutator from Cromwell, sooooo.....
There was a problem hiding this comment.
"No user action is required aside from upgrading Cromwell. But yeah, you need to upgrade your Cromwell."
Fixes runtime warning introduced in #5565
Intentional stowaway: error message improvement for @barkasn