Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
cjllanwarne committed Jan 7, 2019
1 parent b22ec1e commit 8c30a3c
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ workflow afters {
String where = "/tmp/helloFile"
}

# Should not impact 'read' because it happens before the second read:
# Should not impact 'read' because the second write overwrites it:
call write_to_shared as foo1 { input: i = 5, where = where }

# This value should always be the value we get from the read:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ workflow afters {
String where = "/tmp/helloFile"
}

# Should not impact 'read' because it happens before the second read:
# Should not impact 'read' because the second write overwrites it:
call write_to_shared as foo1 { input: i = 5, where = where }

# Scatter once to replace the contents with something else:
Expand All @@ -14,12 +14,7 @@ workflow afters {
}

# The call to 'read':
call read_from_shared
after foo2
{ input:
where = where
# , ready = foo2.done[0]
}
call read_from_shared after foo2 { input: where = where }

# Should not impact 'read' because it happens afterwards:
call write_to_shared as foo3 after read_from_shared { input: i = 77, where = where }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ object ExecutionStore {

key match {
case scatteredCallCompletion: ScatteredCallCompletionKey =>
println(s"${statusTable.row(scatteredCallCompletion.node).size} == ${scatteredCallCompletion.totalIndices}?")
statusTable.row(scatteredCallCompletion.node).size == scatteredCallCompletion.totalIndices
case scatterCollector: ScatterCollectorKey =>
// The outputToGather is the PortBasedGraphOutputNode of the inner graph that we're collecting. Go one step upstream and then
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package wdl.transforms.biscayne.ast2wdlom

import better.files.File
import org.scalatest.{FlatSpec, Matchers}
import wdl.model.draft3.elements.{ExpressionElement, _}
import wdl.transforms.biscayne.ast2wdlom.WdlFileToWdlomSpec._
import wom.types._
import wdl.model.draft3.elements.CommandPartElement.{PlaceholderCommandPartElement, StringCommandPartElement}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ workflow afters {
String where = "/tmp/helloFile"
}

# Should not impact 'read' because it happens before the second read:
# Should not impact 'read' because the second write overwrites it:
call write_to_shared as foo1 { input: i = 5, where = where }

# Conditionally do (and don't) call a write:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ workflow afters {
String where = "/tmp/helloFile"
}

# Should not impact 'read' because it happens before the second read:
# Should not impact 'read' because the second write overwrites it:
call write_to_shared as foo1 { input: i = 5, where = where }

# Scatter once to replace the contents with something else:
Expand Down

0 comments on commit 8c30a3c

Please sign in to comment.