Skip to content

Commit

Permalink
shorten comment
Browse files Browse the repository at this point in the history
  • Loading branch information
THWiseman committed Nov 13, 2023
1 parent c430202 commit 583e3fb
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ object MachineConstraints {
s"predefined-$cpu-${memory.to(MemoryUnit.MB).amount.intValue()}"
} else {
// Users specify a CPU platform in their WDL, but GCP also needs to know which machine type to use.
// The below logic infers the machine type from the requested CPU. We're assuming that users want the newest
// "General Purpose" machine type that is compatible with the requested CPU. For example, if someone requests
// Intel Cascade Lake as their CPU platform, then infer the n2 machine type. AMD Rome -> n2d.
// The below logic infers the machine type from the requested CPU.
// The heuristic we're using is: find the newest 'General Purpose' type that supports the given CPU.
// https://cloud.google.com/compute/docs/machine-resource
// For example, if someone requests Intel Cascade Lake as their CPU platform, then infer the n2 machine type.
// Infer n2d from AMD Rome, etc.
val customMachineType =
cpuPlatformOption match {
case Some(PipelinesApiRuntimeAttributes.CpuPlatformIntelIceLakeValue) => N2CustomMachineType

Check warning on line 27 in supportedBackends/google/pipelines/common/src/main/scala/cromwell/backend/google/pipelines/common/MachineConstraints.scala

View check run for this annotation

Codecov / codecov/patch

supportedBackends/google/pipelines/common/src/main/scala/cromwell/backend/google/pipelines/common/MachineConstraints.scala#L27

Added line #L27 was not covered by tests
Expand Down

0 comments on commit 583e3fb

Please sign in to comment.