DSD. You know it. You want it. You love it. #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://bridgetown-beta-pr-763.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-chl8o9g2qv26h9ltgbc0. |
|
Your Render PR Server URL is https://bridgetown-api-pr-763.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-chl8o9g2qv26h9ltgbi0. |
ayushn21
reviewed
Jun 5, 2023
| @@ -523,6 +523,10 @@ def chomp_locale_suffix!(path, locale) | |||
| end | |||
| end | |||
|
|
|||
| def dsd_tag(input) | |||
There was a problem hiding this comment.
How do you feel about allowing the shadowrootmode to be passed in?
def dsd_tag(shadow_root_mode: :open, input)
raise ArgumentError unless [:open, :closed].contains? shadow_root_mode
%(<template shadowrootmode="#{shadow_root_mode}">#{input}</template>).html_safe
endCo-authored-by: Ayush Newatia <ayush@hey.com>
* Retool esbuild configuration and add islands architecture * Add bundled configuration for <is-land> * Also remove previously deprecated non-Zeitwerk plugin support * Fix some subtle Watcher bugs * Improve esbuild glob functionality * fix cucumber feature for assets * Add preliminary documentation for Islands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: this branch now also includes #765
Render DSD templates like a boss with the
dsdhelper / Liquid tag. 😎Also provides
dsd_stylehelper to inline CSS inside of a DSD template.Todo: