-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(general): Add a job to ensure evaluated keys are added to new resource checks #6958
Conversation
|
||
# Only run checks if not in exceptions list | ||
if [[ "$SKIP_FILE" == "false" ]]; then | ||
# If file contains 'BaseResourceCheck', check for 'get_inspected_key' or 'evaluated_keys' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only a partial validation, as BaseResourceCheck
doesn't exist in all of the code.
for example, if we inherited from it a class called BaseCloudformationResourceCheck
, any check which inerits from this one will not catch this.
I don't mind adding this check for now, but a better solution would be a python linter (flake8-plugin for example) which can catch this issue
…esource checks (#6958) * Add action and example * fix * Fix lint and test case * fix lint
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Added an action job to ensure evaluated keys are added to new or modified python checks
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Adds a new GitHub Actions job to validate that new or modified Python checks include evaluated keys. Implements the
get_evaluated_keys()
method in theAzureMLWorkspacePrivateEndpoint
check class to return the list of evaluated keys.Modified files (1)
Latest Contributors(2)
get_evaluated_keys()
method inAzureMLWorkspacePrivateEndpoint
classModified files (1)
Latest Contributors(2)