Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): add option to add proxy to request #6923

Merged
merged 12 commits into from
Jan 1, 2025

Conversation

lirshindalman
Copy link
Contributor

@lirshindalman lirshindalman commented Dec 24, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Enhances the proxy functionality by introducing custom headers, improving configuration management, and refactoring for better modularity. Implements environment variable-based configuration, updates error handling to use logging, and centralizes proxy-related code. These changes aim to improve the flexibility and robustness of the proxy system across the Checkov framework.

TopicDetails
Error Handling Replaces exception raising with logging for improved resilience in proxy-related operations
Modified files (1)
  • checkov/common/proxy/proxy_client.py
Latest Contributors(0)
UserCommitDate
Module Refactoring Refactors the registry loader to use the common proxy client, improving code organization and reusability
Modified files (1)
  • checkov/terraform/module_loading/loaders/registry_loader.py
Latest Contributors(2)
UserCommitDate
apgruczafix-terraform-Unable-t...June 04, 2023
gruebelchore-add-type-hints-t...May 23, 2023
Proxy Enhancement Enhances the ProxyClient class with custom header support, improves configuration management, and centralizes proxy-related functionality
Modified files (3)
  • checkov/common/proxy/proxy_client.py
  • checkov/common/util/env_vars_config.py
  • checkov/common/proxy/__init__.py
Latest Contributors(2)
UserCommitDate
OfekShimkofeat-sca-support-java-...November 18, 2024
rotemavnifix-terraform-Set-time...October 13, 2024
This pull request is reviewed by Baz. Join @lirshindalman and the rest of your team on (Baz).

checkov/common/proxy/proxy_client.py Outdated Show resolved Hide resolved
checkov/common/proxy/proxy_client.py Outdated Show resolved Hide resolved
checkov/common/proxy/proxy_client.py Outdated Show resolved Hide resolved
@lirshindalman lirshindalman changed the title feat(general): add proxy to git clone from feat(terraform): add proxy to git clone from Jan 1, 2025
@lirshindalman lirshindalman changed the title feat(terraform): add proxy to git clone from feat(terraform): add option to add proxy to request Jan 1, 2025
@lirshindalman lirshindalman merged commit b25fe42 into main Jan 1, 2025
34 of 35 checks passed
@lirshindalman lirshindalman deleted the add_procy_to_git_clone branch January 1, 2025 13:13
Saarett pushed a commit that referenced this pull request Jan 1, 2025
* .

* .

* .

* .

* .

* .

* .

* remove git clone support

* remove git clone support

* remove git clone support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants