-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terraform): Ensure the default IP Restriction action for SCM is set to "Deny" #6115
Open
tdefise
wants to merge
11
commits into
bridgecrewio:main
Choose a base branch
from
tdefise:AppServiceIPResctrictionDefaultActionSCMDeny
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(terraform): Ensure the default IP Restriction action for SCM is set to "Deny" #6115
tdefise
wants to merge
11
commits into
bridgecrewio:main
from
tdefise:AppServiceIPResctrictionDefaultActionSCMDeny
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…//github.com/tdefise/checkov into AppServiceIPResctrictionDefaultActionSCMDeny
Dear Checkov Team, Would it be possible to have a status on this PR please? Kind Regards, |
achiar99
approved these changes
Jul 23, 2024
@tdefise Thanks for you contribution |
itai1357
approved these changes
Jul 23, 2024
Hey @tdefise, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Fixes #6114
New/Edited policies (Delete if not relevant)
Description
Check that ensure that the default IP Restriction action for SCM is set to "Deny"
Fix
Set "scm_ip_restriction_default_action" to "Deny"
Checklist:
Generated description
Dear maintainer, below is a concise technical summary of the changes proposed in this PR:
Implement a new check
AppServiceIPResctrictionDefaultActionSCMDeny
to ensure that the default IP restriction action for SCM in Azure App Services is set to 'Deny'. This check is integrated into the Checkov framework and applies to bothazurerm_linux_web_app
andazurerm_windows_web_app
resources. The check inspects thesite_config
block for thescm_ip_restriction_default_action
key. Additionally, test cases are added to verify the functionality of this check, ensuring it correctly identifies compliant and non-compliant configurations.AppServiceIPResctrictionDefaultActionSCMDeny
to ensure the default IP restriction action for SCM is set to 'Deny'.Modified files (1)
Latest Contributors(0)
AppServiceIPResctrictionDefaultActionSCMDeny
for Azure App Services.Modified files (2)
Latest Contributors(0)