-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terraform): Ensure basic authentication for FTP is disabled #6099
Open
tdefise
wants to merge
9
commits into
bridgecrewio:main
Choose a base branch
from
tdefise:AppServiceFTPBasicAuthenticationDisabled
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(terraform): Ensure basic authentication for FTP is disabled #6099
tdefise
wants to merge
9
commits into
bridgecrewio:main
from
tdefise:AppServiceFTPBasicAuthenticationDisabled
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub.com/tdefise/checkov into AppServiceFTPBasicAuthenticationDisabled
Dear Checkov Team, Would it be possible to have a status on this PR please? Kind Regards, |
Hi @tdefise, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Fixes #6098
New/Edited policies (Delete if not relevant)
Description
App Service provides basic authentication for FTP and WebDeploy clients to connect to it by using deployment credentials. These APIs are great for browsing your site’s file system, uploading drivers and utilities, and deploying with MsBuild. However, enterprises often require more secure deployment methods than basic authentication, such as Microsoft Entra ID authentication (see Authentication types by deployment methods in Azure App Service).
cc https://learn.microsoft.com/en-us/azure/app-service/configure-basic-auth-disable?tabs=portal
Fix
Set "ftp_publish_basic_authentication_enabled" to 'false
Checklist:
Generated description
Dear maintainer, below is a concise technical summary of the changes proposed in this PR:
Implement a new check
AppServiceFTPBasicAuthenticationDisabled
to ensure that basic authentication for FTP is disabled in Azure App Services. This check is added to thecheckov
library and targets resourcesazurerm_linux_web_app
andazurerm_windows_web_app
. The check verifies that theftp_publish_basic_authentication_enabled
property is set tofalse
. Additionally, test cases are provided to validate the functionality of this check, ensuring that both passing and failing scenarios are covered.Modified files (2)
Latest Contributors(0)
Modified files (1)
Latest Contributors(0)