Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Android AVD after test build and use more RAM on the emulator. #496

Closed
wants to merge 1 commit into from

Conversation

pietro
Copy link
Contributor

@pietro pietro commented Mar 29, 2017

This way we'll get to build issues faster.

@@ -88,7 +88,9 @@ fi
case $TARGET_X in
armv7-linux-androideabi)
cargo test -vv -j2 --no-run ${mode-} ${FEATURES_X-} --target=$TARGET_X
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment about why we're doing this here.

Also, would it be possible/beneficial for us to create the AVD once, have Travis CI cache it, and then make a copy of the cached AVD that we then run the tests on?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add the comment.

I thought about caching the AVD but that would slow down all builds. And it will get worse when we add AArch64 Android to Travis.

@coveralls
Copy link

coveralls commented Mar 29, 2017

Coverage Status

Coverage remained the same at 93.987% when pulling 52a3b2a on pietro:android_emulator into b592277 on briansmith:master.

@briansmith
Copy link
Owner

Thanks for pointing out the potential issue with caching the AVD. I landed your change as 4a13608 in master and I added efb4b0e to document why we do things in this order.

Thanks a lot!

@briansmith briansmith closed this Apr 15, 2017
@briansmith briansmith added this to the 0.8.n milestone Apr 15, 2017
@pietro
Copy link
Contributor Author

pietro commented Apr 18, 2017

I think I'm wrong about the AVD caching issue. I think it would be ok to cache $HOME/.android or at least $HOME/.android/avd and check if /home/travis/.android/avd/arm-18.avd exists before creating the AVD for ARMv7a.

According to Travis CI caching docs the ENV vars we export on each build is taken in consideration when creating/using the cache so non-android builds won't have the AVD cache.

@briansmith
Copy link
Owner

@pietro Thanks for pointing that out. I filed #518 to track that so we don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants