Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ImagePaletteServiceProvider.php #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

manticorp
Copy link

This makes it compatible with the current latest version of laravel, which removed the share method from the application container.

@akempes
Copy link

akempes commented Mar 29, 2017

@manticorp I tried your update but it isn't working for Laravel 5.3 and 5.4. I had to change it to:

$this->app->singleton('image-palette', function () {
	return new Client;
});

@manticorp
Copy link
Author

Yes this is true actually - the array access set doesn't set a shared binding, but a call to singleton does - nicely spotted.

@akempes
Copy link

akempes commented Mar 29, 2017

One more thing: To support Laravel 5 you need to remove the line $this->package('brianmcdo/image-palette');. In fact the whole boot function may be removed.

@manticorp
Copy link
Author

Aha fair game - thanks for the heads up - have again updated :)

@akempes
Copy link

akempes commented Mar 29, 2017

Thanks for the FAST updates! This last update also fixes issue #6.

I hope this pull request is merged soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants