GitHub Actions: Add CentOS/Fedora cases. #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CIs are OK. GitHub Actions log ubuntu, container, Travis log on my forked repository. |
Closed
* Migrate CentOS case in Travis to GitHub Actions. * Add Fedora cases as allow failure.
23a7f39 to
53aee58
Compare
|
Continues to look really good! |
|
Thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notes
.github/workflows/container.ymlas a workflow to test on a container. This file includes the migrated centos case and newly added fedora case. For now, I'd like to add the fedora cases because it has the test failure reported on the issue ticket. I'd like to share the reproductive cases here as I need someone's help to fix it. After fixing it, it might be dropped again if someone does not like it.test.ymltoubuntu.yml. The file name might be renamed to such asubuntu_osx.ymlin near future if the MacOSX case will be added to this file. But I thinkubuntu.ymlis accurate name for now..dockerignore: I added this file to avoid the unintended file is copied to the container from host environment such asspec/configuration.ymlespecially in the use case debugging on local environment.