-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to install 'charlock_holmes_bundle_icu' on Mavericks #49
Comments
Here's a gist of the mkmf.log. https://gist.github.com/silasj/7bbe41bcb76ca3c91566 |
Also seeing this, I guess it's the same upstream icu issue as Homebrew/legacy-homebrew#20545 |
Possibly, but I can install icu4c with homebrew without issue. |
@silasj homebrew has updated the version of icu. You can use the version of this gem from my pull request by adding this to your Gemfile gem 'charlock_holmes', github: "tooky/charlock_holmes", branch: "bundle-icu" |
Thanks! This'll definitely help. |
@tooky, I'm on 10.9 and am trying to use your fork of charlock_holmes and having a strange problem -- it appears to install correctly using bundler but the gem isn't available. I added the following to my Gemfile:
And running bundle install I see it getting installed:
The bundle install command appears to complete without error and I can list charlock_holmes with bundle:
But if I look for charlock_holmes with the gem command it isn't there:
And I can't require it:
|
Use simple command-line git invocations in following scripts instead of grit fork. ./script/generate-js-version.rb ./script/update-git-commit-and-branch.rb gitlab-grit dependency charlock_holmes not working correctly in Mac OS X 10.9 see: brianmario/charlock_holmes#49
It's being installed by bundler so you will need to use bundler to access e.g.
or
On 22 November 2013 16:18, Stephen Bannasch notifications@github.comwrote:
Steve Tooke :: heavi.es Heavies Limited |
Instead of using the bundle_icu gem, I just created a custom buildback with icu4c installed. It is a fork off of the latest heroku-buildpack-ruby (default ruby buildpack). Anyone who wants to use it is welcome. I will try to keep it updated with the latest from the main fork. Using a custom buildpack versus the bundle_icu gem has many advantages, namely, faster deploy times, and a small slug.
|
This pull request includes changes intended to allow the resolution of brianmario#29, brianmario#40, brianmario#42 (partial), brianmario#43, brianmario#49, brianmario#50, brianmario#51, brianmario#52. - file/libmagic (and patch) updated to 5.16. - extconf.rb modified to: - enforce RbConfig compiler and related flags. - fix for non-GNU 'make' (ie, no ```make -C```). - remove 'dst' build directory after compiling. - **Build and link against system ICU on Darwin.** I've included a minimal subset of the ICU headers in ```darwin-icu-headers.tar.gz```, taken from the [Apple ICU](http://www.opensource.apple.com/source/ICU/ICU-461.18) source (Apple doesn't distribute these headers because they prefer you use their client frameworks like Core Text, etc., but they're available freely at the link above). These headers are from the version bundled with 10.7 (10.6 was too old, so I've retained the check for homebrew icu4c on older versions). I've tested that they work on 10.9, so presumably it should work on 10.7 and 10.8 as well. If anyone can confirm that, that would be great. I think perhaps this is a better solution than relying on ```brew install icu4c```?
This pull request includes changes intended to allow the resolution of brianmario#29, brianmario#40, brianmario#42 (partial), brianmario#43, brianmario#49, brianmario#50, brianmario#51, brianmario#52. - file/libmagic (and patch) updated to 5.16. - extconf.rb modified to: - enforce RbConfig compiler and related flags. - fix for non-GNU 'make' (ie, no ```make -C```). - remove 'dst' build directory after compiling. - **Build and link against system ICU on Darwin.** I've included a minimal subset of the ICU headers in ```darwin-icu-headers.tar.gz```, taken from the [Apple ICU](http://www.opensource.apple.com/source/ICU/ICU-461.18) source (Apple doesn't distribute these headers because they prefer you use their client frameworks like Core Text, etc., but they're available freely at the link above). These headers are from the version bundled with 10.7 (10.6 was too old, so I've retained the check for homebrew icu4c on older versions). I've tested that they work on 10.9, so presumably it should work on 10.7 and 10.8 as well. If anyone can confirm that, that would be great. I think perhaps this is a better solution than relying on ```brew install icu4c```?
@webandtech I've been using your custom buildpack for a while now, and it's been working great, but today my deployments started failing with the following error:
|
@silasj Sorry about that. I didn't know anyone was using it and updated it to try something else. I rolled it back, so you should be all set. I have decided to stop maintaining this though, so you may want to make your own or take another approach eventually. Personally, I have started to deploy with jruby and had to move to a java version - icu4j. |
@webandtech No worries. I've never worked with a custom buildpack. Do I just fork yours and push the buildpack to heroku? |
@silasj since @webandtech is not maintaining his fork any more (and who can blame him?!) I've come up with a new method which should be virtually maintenance free - always using the up to date
|
@benjie I don't care (myself) one bit — not my project — but can I just double check (for sake of my own ignorance), the last few posts have made the jump from a Heroku build-pack which could also be used on Mac OS X to being purely about Heroku correct? I make mention of it just since (as it seems you've found a nice solution for that problem), perhaps create a separate PR/issue, simply because anyone looking for your solution are unlikely to look 12 posts down on an issue called |
@g--n I agree. This issue has kinda wandered across several topics that, while somewhat related, the solutions aren't very discoverable. |
@g--n @silasj Though I agree in principle, this thread is the third hit on google (for me) for |
@silasjmatson @benjie FYI I decided to rebase my buildpack from the latest heroku buildpack and I will maintain it as I'm able. The fork is also available at https://github.com/webandtech/heroku-buildpack-ruby |
I get the following error when trying to install on OS X Mavericks:
The text was updated successfully, but these errors were encountered: