Fixed formatting for new listing & adding github action support #51
Conversation
|
Adding github action support means automatically building docker images and pushing them to docker hub. Keep in mind you need to add DOCKER_USERNAME and DOCKER_PASSWORD to your github secretes. |
Seems to have some issue with access. Not sure if it's due to it not being linked to the current repo, but since both repos are public it shouldn't have been in a problem in theory i think. docker/build-push-action#88
|
|
Did you set DOCKER_USERNAME and DOCKER_PASSWORD or your docker hub account? If yes was it executed with the newest Dockerfile? Last solution idea: did you change the library name in the main.yml? maybe you do not have rights to access my library on docker hub :) |
|
Yep DOCKER_USERNAME and DOCKER_PASSWORD was already set up. Dockerfile used was the latest version in the repo if that's what you were referring to. I just changed library name in main.yml to brianleect/binance-pump-alerts.
I might be setting up docker wrongly. Thanks for the suggestions will see if I can figure out what I'm doing wrong. Worst case I'll likely just leave it since I'm not actively using docker atm as well. The feature seems pretty neat though. |
|
Can you give me rights on the repo so that I can check?
…On Sun, Aug 22, 2021 at 5:32 PM Brian Lee Cheow Teng < ***@***.***> wrote:
[image: image]
<https://user-images.githubusercontent.com/63389110/130360831-dc878dad-f4df-4cc5-bde7-2e9d07ee0fd0.png>
Yep DOCKER_USERNAME and DOCKER_PASSWORD was already set up. Dockerfile
used was the latest version in the repo if that's what you were referring
to. I just changed library name in main.yml to
brianleect/binance-pump-alerts.
[image: image]
<https://user-images.githubusercontent.com/63389110/130360928-438f3392-13c6-442f-b393-140fdcd96215.png>
I might be setting up docker wrongly possible >.> . Thanks for the
suggestions will see if I can figure out what I'm doing wrong.
Worst case I'll likely just leave it since I'm not actively using docker
atm as well. The feature seems pretty neat though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADDJ7FOY43HFMCLNRLKJP3T6EKATANCNFSM5CSV77XQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
|
you need to create a repo on Docker Hub
<https://hub.docker.com/repositories> upfront. This is the one you push too.
Best,
Patrick
On Sun, Aug 22, 2021 at 5:34 PM Patrick Baumgartner <
***@***.***> wrote:
… Can you give me rights on the repo so that I can check?
On Sun, Aug 22, 2021 at 5:32 PM Brian Lee Cheow Teng <
***@***.***> wrote:
> [image: image]
> <https://user-images.githubusercontent.com/63389110/130360831-dc878dad-f4df-4cc5-bde7-2e9d07ee0fd0.png>
>
> Yep DOCKER_USERNAME and DOCKER_PASSWORD was already set up. Dockerfile
> used was the latest version in the repo if that's what you were referring
> to. I just changed library name in main.yml to
> brianleect/binance-pump-alerts.
>
> [image: image]
> <https://user-images.githubusercontent.com/63389110/130360928-438f3392-13c6-442f-b393-140fdcd96215.png>
>
> I might be setting up docker wrongly possible >.> . Thanks for the
> suggestions will see if I can figure out what I'm doing wrong.
>
> Worst case I'll likely just leave it since I'm not actively using docker
> atm as well. The feature seems pretty neat though.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#51 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AADDJ7FOY43HFMCLNRLKJP3T6EKATANCNFSM5CSV77XQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
> .
>
|
You are right, I did not create the repo previously. It works after I created the repo! Thanks for helping to debug!
|
No description provided.