Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for configurable fractional percentile metrics in output file... #863

Merged
merged 1 commit into from
Nov 18, 2016

Conversation

jschmieg
Copy link
Contributor

@jschmieg jschmieg commented Oct 18, 2016

I added support for Double values in percentile metrics. Configuration is not changed: values are defined in hdrhistogram.percentiles, but with this modification, it accepts Double values.

@risdenk
Copy link
Collaborator

risdenk commented Oct 18, 2016

@jschmieg is this a duplicate of PR #862?

@jschmieg
Copy link
Contributor Author

Yes,it is. I requested it again to see Travis build status, which failed at first time.

@risdenk
Copy link
Collaborator

risdenk commented Oct 19, 2016

ok just closed #862. We can focus on this PR. I can take a look at the failing travis ci tests.

@risdenk
Copy link
Collaborator

risdenk commented Nov 15, 2016

@jschmieg Does this change the output format for integers? If you put in say 95 will it output 95.0?

@jschmieg
Copy link
Contributor Author

Hi @risdenk ,
it doesn't change format of integers. They still look like this:
[INSERT], 95thPercentileLatency(us), 700.0
For double values output is like this:
[INSERT], 99.9PercentileLatency(us), 18415.0

@risdenk risdenk merged commit 1d37be1 into brianfrankcooper:master Nov 18, 2016
@risdenk
Copy link
Collaborator

risdenk commented Nov 18, 2016

Thanks @jschmieg

@risdenk risdenk mentioned this pull request Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants