[couchbase2] logical error in decode() #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dataintegrity=true, no field values in passed to verifyRow() for verify and keep on getting error.
|
this looks correct to me. mind taking a quick look @daschl ? |
|
yup makes sense |
|
yes cherry-pick it please, I can do the testing for 0.10 |
|
I think that commit requires the SDK update too? Can we take this discussion over to #772? |
Closed
|
@busbey this commit introduced a regression, fixing it right now. |
daschl
added a commit
to couchbaselabs/YCSB
that referenced
this pull request
Jul 4, 2016
this properly fixes brianfrankcooper#786 which has been reverted since it has some side effects on other workloads and causes regressions.
busbey
pushed a commit
that referenced
this pull request
Jul 4, 2016
this properly fixes #786 which has been reverted since it has some side effects on other workloads and causes regressions.
steffenfriedrich
pushed a commit
to steffenfriedrich/YCSB
that referenced
this pull request
Aug 22, 2016
this properly fixes brianfrankcooper#786 which has been reverted since it has some side effects on other workloads and causes regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dataintegrity=true, no field values in passed to verifyRow() for verify and keep on getting error.