[couchbase2] Update Java SDK version, query for workloade #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using RAW queries reduces overhead at cbq-engine on the cluster and reduces transport. This in turn delivers lower latencies and thus higher throughput with YCSB's tight loops of requests. Adding an ORDER BY maintains strict correctness with the intended implementation of Workload E. In this particular case, the ORDER BY is effectively a noop since the index in use is ordered anyway. The README for couchbase2 was also updated to reflect the simpler index creation which is possible with Couchbase Server 4.5. Server 4.5 automatically covers on the primary index so there is no need for the more complicated syntax unless using an older version. Note this change requires the 2.3.1 Couchbase Java SDK and its underlying core-io 1.3.1. The core-io 1.3.1 adds a streaming parser for RAW results.
|
I looked at the build check, it seems to be a missing dependency from the cassandra binding? I don't think it's related to my change. |
|
@busbey what do you think? I'm 👍 on the change :) |
|
Let's retry the build failures and make sure it's just flakeys |
|
Woo, pass that time @busbey ! |
|
Thanks @busbey ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a dependency update.
Atop that, there's a change to the query to use RAW results. More in the commit message there.