[mongodb] return OK on updates with w=0 #759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #746 it was found that when using the
mongodb-async
binding with a write concern ofw=0
then update operations will always return-1
which in turn reports an operation status ofNOT_FOUND
.Since you cannot tell what the result of the update operation is whne you fire and forget, it is reasonable to just return success for all update operations in the
mongodb-async
binding when using a write concern ofw=0
.