-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hbase] Changes to support secured HBase cluster #591
Conversation
please start commit messages with just then name of the module impacted (i.e. "[hbase098]" rather than "changes to hbase098" |
Do you have some perf numbers to show the actual impact? Why only do this change in the 0.98 driver? |
If you're going to add properties for the principal and keytab, please document them
Are these changes needed to run on a kerberos cluster? I was under the impression the one merely needed to kinit before running YCSB and the hbase driver would correctly use the cached tickets? |
} | ||
} | ||
try { | ||
_hConn = HConnectionManager.createConnection(config); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where does this get closed? should either ref count or register a shutdown hook
Note also that #350 has been waiting for verification of essentially the same keytab functionality. |
Thanks @busbey for the review and feedback.
|
👍 from me |
[hbase] Changes to support secured HBase cluster
Thanks for the contribution! |
[hbase] Changes to support secured HBase cluster
[hbase] Changes to support secured HBase cluster
Changes in this pull request include
For hbase098
connection
object to createtable
objectFor hbase10
If users like to use kerberos keytab to make the connection to secure hbase cluster instead of using the
user-id
of the user running the test they can be passed usingprincipal=keytab-principal-name
andkeytab=keytab=file
properties.Update: After the conversation in issue #322 , changes were made to hbase098 and hbase10 to use single HBase connection across all the threads when running a multi-thread test.