Switch unordered key generation from FNV32 to FNV64 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2011 16:57
…on-colliding keys. Unforunately, for reasonably sized workloads, this leads to key collisions, which throws off experiments. The implementations of the FNV32 and FNV64 hash functions we use manipulate signed integers instead of unsigned integers, so it is unclear if this is a limitation of the FNV algorithms or of our implementations. As a workaround, this patch switches from FNV32 to FNV64, reducing the chances of such bad behavior (and eliminating it in our experiments to date).
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
hse-project
pushed a commit
to hse-project/hse-ycsb
that referenced
this pull request
Apr 17, 2020
….0-LargeRecordCount-patch to hse-0.17.0-LargeRecordCount * commit '2741469f54e8e85b95df59e1afd48f36d772cc99': Change ITEM_COUNT to 40 billion long variable conversion for large record count
hse-root
pushed a commit
to hse-project/hse-ycsb
that referenced
this pull request
Aug 26, 2021
Merge in HSE/hse-ycsb from updates/SSVG-3593-template to v0.17.0-hse * commit '7911d52c56345585a0c41c8fffcab91e50077d56': Fix feature request template
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a code cleanup and bug fix.
I was seeing collisions on unordered workloads. As a workaround, I switched from FNV32 to FNV64, and the problem went away.