[core] Fix #380 by working around recorder/logger initialization timing. #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you redo the commit message to start the first line with "[core]"? |
|
could you amend to leave out the formatting changes? |
The HdrHistogramReader makes some problematic assumptions on the roles played by start time, base time and histogram start/end times. This is to be revisited in a future release of HdrHistogram (see HdrHistogram/HdrHistogram#69). In the meantime this change will make YCSB record as expected by the reader: a. Set histogram log base time (same as start time) b. Only create the recorder after the log has been setup
|
Learned a new git trick in the process ;) |
busbey
added a commit
that referenced
this pull request
Aug 6, 2015
[core] Fix #380 by working around recorder/logger initialization timing.
|
Thanks! |
Closed
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
[core] Fix brianfrankcooper#380 by working around recorder/logger initialization timing.
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
[core] Fix brianfrankcooper#380 by working around recorder/logger initialization timing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HdrHistogramReader makes some problematic assumptions on the roles played by start time, base time and histogram start/end times. This is to be revisited in a future release of HdrHistogram (see HdrHistogram/HdrHistogram#69). In the meantime this change will make YCSB record as expected by the current reader:
a. Set histogram log base time (same as start time)
b. Only create the recorder after the log has been setup