added truncate functionality to DB class, pushed it through to all implementors #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t Boolean (was causing ClassCastException
…, they're not in the upstream repo yet
|
Hey, Should I still merge it? Does it work with the other changes I merged to Voldemort, Cassandra and Mongo? Thanks! Brian |
hse-root
pushed a commit
to hse-project/hse-ycsb
that referenced
this pull request
Aug 21, 2020
…age-lrc to v0.17.0-lrc-hse * commit 'ebe932f462211ccf097348a6ee201857f53dd6aa': Merge pull request brianfrankcooper#27 in HSE/hse-ycsb from make-package to v0.17.0-hse (cherry picked from commit 943db6bdc7ad65383f3c29d4bae4ea9a6fcf54f2)
hse-root
pushed a commit
to hse-project/hse-ycsb
that referenced
this pull request
Aug 21, 2020
…age-lrc-1.8 to v0.17.0.2.1-lrc-hse-1.8.0 * commit '235251333f711c31cd07e9346b24f19c7747be6a': Merge pull request brianfrankcooper#28 in HSE/hse-ycsb from make-package-lrc to v0.17.0-lrc-hse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However some of them (Mongo 5,6, HBase, Voldemort) are empty implementations. I primarily did this for Mongo b/c I would have to clean it out in order to re-insert data. I assume there will be other doc stores that have the same problem.