-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Info on clipBlack setting in chroma effect #80
Comments
e, I'm so glad you're pleased with the library so far. I'd love to see the work you've done with it once you're ready to share. I'm not quite sure exactly what's going on here without knowing how you've set up the composition. It looks like there are at least a couple of compositing passes here - I see the white background with the shiny pink thing behind you and also the black spots on the faces and hands. So I'll try my best to explain how First of all,
These two properties both affect the alpha value of the output. The chroma filter makes an attempt to give a smooth transition between foreground and background. If the dominant color channel of any given pixel is not the same as the dominant channel (RGB) of the screen color, then that pixel is solid (i.e. alpha = 1). If the dominant color component matches and the saturation is at least as high as the screen color, then we can be pretty confident that that pixel is background (alpha = 0). If the dominant component matches, but the saturation is not as high as the screen color, then we fall somewhere in the middle. This is where If the resulting alpha value is less than the value of Let me know if that helps. If not, feel free to share some working code or provide a more detailed description of how your nodes are set up. Brian |
If the only effect you're using is chroma and you're not setting the I wonder if there is something specific to your GPU driver and the way it's handling the particular shader functions I'm using. Are you on Linux? Can you share the details on your GPU and OS? |
Yes only effect is chroma. I'm using the examples without any modifications. Yes, I'm on linux mint 16, 64bits, with a GeForce GTX 770 and nvidia drivers installed. |
Okay, we're in business. Looks like I'm seeing the problem on my home machine, but not my work machine. Now I can debug it. Stay tuned... |
Try that. There was a divide-by-zero error. I guess on some machines it was ignoring it because the alpha value of the resulting color was zero anyway. |
Thanks! Checking it right now |
Great! Thanks for catching this one. |
Great, brianchirls' fix really does the trick. However, I had to spend a few hours to figure this out, so it would be great if this could be integrated into the downloadable version as soon as possible. Thanks for the good work! |
I ran into this exact problem on an iPad 2, Safari 9 (and Chrome 33) on iOS 9.3 today. Of course tweaking this value might produce unexpected results on some other systems (though in this case it still works fine on my PC as well) but it might proof useful when optimizing for a specific device (like I'm doing with this iPad 2: the page I'm making will not be visited on other devices).
edit:
|
@javl Have you tried setting the precision to |
@brianchirls Just tried: gives me the odd banding / grouping of colored pixels again. I can't take a screenshot on the actual device but uploaded a photo of the screen. You can see artifacts on the ceiling and next to the lamp in the picture when the precision is set to 1/255.0. With the original settings these areas are black. set to 1/255.0 (artifacts on ceiling): https://imgur.com/kCQKxl8 Note the chairs in the image which are keyed and show a dark pattern through them. The actual keying of those chairs is fine in both images and could be even better with some finetuning, it's just the one with 1/255.0 that has those artifacts. |
Hey @brianchirls
Thanks for this super lib. The more I use it the more I love it ;)
I'm trying some effects with chroma key and I have some questions on it.
Sorry that's not really an issue but more a forum question on how to use.
Anyway,
The green detection is working great, as seen in this screencap:
(settings used in the bottom right corner)
But when I slide the clipBlack to 0, I'm expecting to see the full body, but I'm still seeing some black pixels on my face :)
I thought clipBlack and clipWhite were tools to setup the chromakey but not used after.
I guess I'm getting it wrong.
How could I slide the clipBlack "below 0" to have no black incrust at all?
Thanks in advance for your answer.
cheers,
e
The text was updated successfully, but these errors were encountered: