Skip to content

Commit

Permalink
Comments for CRAN submission
Browse files Browse the repository at this point in the history
  • Loading branch information
Brian Boonstra committed May 19, 2019
1 parent 9ffde10 commit 3c8f5a5
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
## Submission comments
Version raised to 1.1, still no bugs in 3 years. One minor enhancement: added a helper function to use daycount capabilities of BondValuation package.
Version raised to 1.1, still no known bugs in 3 years.

One minor enhancement: added a helper function to use daycount-derived coupon dates as output in the list object from BondValuation package.

This does not introduce BondValuation as a dependency, since the only actual use of BondValuation is a call in the vignette.

## Test environments
* local MacOS 10.14.4 install, R 3.5.1
* Ubuntu 14.04.5 LTS (on travis-ci), R 3.5.1
* win-builder, R unstable 2018-12-13 r75848
* Ubuntu 14.04.5 LTS (on travis-ci), R 3.6.0
* win-builder, R unstable 2019-05-16 r76519

## R CMD check results
There were no ERRORs, WARNINGs or NOTEs.
Expand Down

0 comments on commit 3c8f5a5

Please sign in to comment.