Add support for github tokens for private repos. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For anyone who wants to use this already, this branch provides a packaged dist: https://github.com/Marenz/check-for-changed-files/tree/token-support-packaged So you can use this with |
brettcannon
requested changes
Jul 31, 2023
action.yml
Outdated
| @@ -19,6 +19,10 @@ inputs: | |||
| description: "String template used when the check fails" | |||
| required: false | |||
| default: "the prerequisite file pattern ${prereq-pattern} matched changed files in the pull request, but the ${file-pattern} pattern did NOT and the ${skip-label} label is not set" | |||
| token: | |||
| description: "Github token to use to checkout the pull request files." | |||
There was a problem hiding this comment.
Suggested change
| description: "Github token to use to checkout the pull request files." | |
| description: "GitHub token to use to checkout the pull request files." |
README.md
Outdated
| @@ -41,6 +41,11 @@ The message to emit when the check fails. All other inputs can be specified in | |||
| the message using `${}` syntax, e.g. `${file-pattern}` for the `file-pattern` | |||
| input. All values will be quoted for easy identification of any whitespace. | |||
|
|
|||
| ### `token` | |||
|
|
|||
| Github token to use for private repositories. Falls back to anonymous access if | |||
There was a problem hiding this comment.
Suggested change
| Github token to use for private repositories. Falls back to anonymous access if | |
| A GitHub auth token to use for private repositories. Falls back to anonymous access if |
Is there a good URL to point users to for what sort of token to request?
There was a problem hiding this comment.
In most cases probably using ${{ secrets.GITHUB_TOKEN }} should be enough.
|
This change is failing CI due to not having the |
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
|
I addressed all comments and mentioned the github secrets that usually is used in that place |
brettcannon
approved these changes
Aug 4, 2023
|
Thanks! I will work on getting a new release out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.