Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty VCF header reference attribute in VCF files produced via Smoove commands #58

Closed
WimSpee opened this issue Feb 12, 2019 · 2 comments

Comments

@WimSpee
Copy link

WimSpee commented Feb 12, 2019

I get this downstream error when trying to read a SV VCF file created with Smoove.

    raise ValueError("Empty VCF header reference attribute is not allowed. Check VCF/BCF header for the 'reference' value.")
ValueError: Empty VCF header reference attribute is not allowed. Check VCF/BCF header for the 'reference' value.

In the final pasted square VCF the reference attribute is indeed empty.
This also the case in all the intermediate VCF files (each call VCF, the merged sites VCF, each genotype VCF)

##reference=

The Smoove call, merge and genotype commands require the fasta on the command line. So it should be possible to set this attribute in the header for the intermediate and the final pasted VCF.

@brentp
Copy link
Owner

brentp commented Feb 12, 2019

I can get this into the next release, but I'm pretty sure this is not required by the spec, so your parser is a bit over-zealous.

@WimSpee
Copy link
Author

WimSpee commented Feb 12, 2019

Thank you. It is indeed just an internal requirement, not in the part of the VCF spec.
In some scripts we use the VCF header to find back FASTA file used to create the file.

Thank you for adding it.

@brentp brentp closed this as completed in a140533 Feb 12, 2019
brentp added a commit that referenced this issue Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants