Remove tokio runtime #239
Merged
Remove tokio runtime #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! So then can also be removed? |
@ok300 No, they are used on uniFFI bindings. Perhaps @dangeross could look into Async/Future support to see if they can be removed as well. |
|
Alright thanks, then lets keep those dependencies for now. |
Merged
1239d96 to
4496dc9
Compare
|
Rebased on top of main to apply these changes to |
dangeross
approved these changes
May 30, 2024
ok300
approved these changes
May 30, 2024
4496dc9 to
39f3443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on
After reading @dangeross's comment on:
I realized we were still relying on Tokio runtime to on Dart bindings of Liquid SDK.
Changelist: