Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix float number in property value #32

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Conversation

brd6
Copy link
Owner

@brd6 brd6 commented Nov 29, 2023

Description

Updated NumberValueProperty class to handle decimal values by changing the type from int to float.

Motivation and context

Fixes an issue where decimal numbers in Notion databases were incorrectly rounded down, impacting data accuracy.

How has this been tested?

Tested in PHP 8.1, ensuring decimal numbers are now accurately handled without adverse side effects.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@brd6 brd6 force-pushed the fix/float-number-property-value branch from dda321d to 8aaf9a4 Compare November 29, 2023 20:40
@brd6
Copy link
Owner Author

brd6 commented Nov 29, 2023

Fix #31

@brd6 brd6 merged commit f0cb787 into main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant