This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Add multi-channel support to updateBrowser.js
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o `common.js` Fixes brave/browser-laptop#11795 Auditors: @aekeus
bsclifton
commented
Nov 20, 2017
bin/uploadBrowser.js
Outdated
@@ -72,7 +72,7 @@ var OS_IDENTIFIER = 2 | |||
// Recipe tuples containing local relative paths to files, key locations on S3, and an os identifier | |||
var recipes = [ | |||
// Linux | |||
['dist/Brave.tar.bz2', 'multi-channel/releases/CHANNEL/VERSION/linux64', 'linux'], | |||
['dist/Brave{{channelName}}.tar.bz2', 'multi-channel/releases/CHANNEL/VERSION/linux64', 'linux'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one I missed last time... not important though, since Linux users can't upgrade without apt/yum/dnf
darkdh
approved these changes
Nov 21, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@aekeus can you please review this one? 😄 |
…atting (ex: `{{version}}`, `{{channel}}`)
27f41b0
to
3e71b43
Compare
Before anyone starts reviewing / rereviewing, please let me run some tests to make sure this works great as expected 😄 Maybe this can be reviewed again next week |
I updated Jenkins to use this code and did a Beta build- update worked great! 😄 Updated from: Here are logs from the update:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multi-channel support to
updateBrowser.js
. Pull common code intocommon.js
Fixes brave/browser-laptop#11795
Auditors: @aekeus