Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Add multi-channel support to updateBrowser.js #3

Merged
merged 2 commits into from
Jan 23, 2018

Conversation

bsclifton
Copy link
Member

Add multi-channel support to updateBrowser.js. Pull common code into common.js

Fixes brave/browser-laptop#11795

Auditors: @aekeus

@bsclifton bsclifton self-assigned this Nov 20, 2017
@bsclifton bsclifton requested review from aekeus and darkdh November 20, 2017 22:29
@@ -72,7 +72,7 @@ var OS_IDENTIFIER = 2
// Recipe tuples containing local relative paths to files, key locations on S3, and an os identifier
var recipes = [
// Linux
['dist/Brave.tar.bz2', 'multi-channel/releases/CHANNEL/VERSION/linux64', 'linux'],
['dist/Brave{{channelName}}.tar.bz2', 'multi-channel/releases/CHANNEL/VERSION/linux64', 'linux'],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one I missed last time... not important though, since Linux users can't upgrade without apt/yum/dnf

Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bsclifton
Copy link
Member Author

@aekeus can you please review this one? 😄

…atting (ex: `{{version}}`, `{{channel}}`)
@bsclifton bsclifton force-pushed the multi-channel-part2 branch from 27f41b0 to 3e71b43 Compare January 19, 2018 19:37
@bsclifton
Copy link
Member Author

Before anyone starts reviewing / rereviewing, please let me run some tests to make sure this works great as expected 😄 Maybe this can be reviewed again next week

@bsclifton
Copy link
Member Author

I updated Jenkins to use this code and did a Beta build- update worked great! 😄

Updated from: 0.20.14 to 0.20.19

Here are logs from the update:

2018-01-23T05:08:14.056Z - checkForUpdates
2018-01-23T05:08:14.056Z - lastCheckYMD = 2018-01-22
2018-01-23T05:08:14.056Z - lastCheckWOY = 19
2018-01-23T05:08:14.056Z - lastCheckMonth = 1
2018-01-23T05:08:14.056Z - weekOfInstallation= 2017-12-18
2018-01-23T05:08:14.056Z - firstCheckMade = true
2018-01-23T05:08:14.056Z - promoCode = none
2018-01-23T05:08:14.056Z - https://laptop-updates.brave.com/1/releases/beta/0.20.14/osx?daily=false&weekly=false&monthly=false&first=false&woi=2017-12-18&ref=none&accept_preview=false
2018-01-23T05:08:14.455Z - Metadata: {"version":"0.20.19","name":"Brave 0.20.19","pub_date":"2018-01-23T05:10:43.282Z","notes":"More details: https://github.com/brave/browser-laptop/releases/tag/v0.20.19beta\n\nMore details: https://github.com/brave/browser-laptop/releases/tag/v0.20.17\nbeta\n\nMore details: https://github.com/brave/browser-laptop/releases/tag/v0.20.16\nbeta\n\nMore details: https://github.com/brave/browser-laptop/releases/tag/v0.20.15\nbeta","preview":false,"url":"https://brave-download.global.ssl.fastly.net/multi-channel/releases/beta/0.20.19/osx/Brave-Beta-0.20.19.zip"}
2018-01-23T05:08:14.672Z - update downloading
2018-01-23T05:08:37.070Z - update downloaded
2018-01-23T05:08:37.070Z - Release notes : More details: https://github.com/brave/browser-laptop/releases/tag/v0.20.19beta

More details: https://github.com/brave/browser-laptop/releases/tag/v0.20.17
beta

More details: https://github.com/brave/browser-laptop/releases/tag/v0.20.16
beta

More details: https://github.com/brave/browser-laptop/releases/tag/v0.20.15
beta
2018-01-23T05:08:37.070Z - Release date: Brave 0.20.19
2018-01-23T05:08:37.070Z - Update URL: Wed Dec 31 1969 17:00:00 GMT-0700 (MST)

@bsclifton bsclifton merged commit fc14d62 into master Jan 23, 2018
@bsclifton bsclifton deleted the multi-channel-part2 branch January 23, 2018 05:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants