This repository has been archived by the owner on May 2, 2023. It is now read-only.
Don't use cert cache when in an enclave. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 30, 2022 08:32
There are several places in the code where we want to know if we're running inside an enclave or not. To simplify the code, we only check once, at package initialization. Subsequent queries can then refer to a global variable.
We don't need a certificate cache when we're running inside an enclave because when the enclave is gone, the certificate cache will be gone as well. Besides, the certificate cache makes it more difficult for the enclave to switch to an unprivileged user before execution because we now have to deal with the permissions of the cache directory and its content. This fixes #35.
rillian
approved these changes
Oct 3, 2022
Comment on lines
-307
to
-308
| if err = os.MkdirAll(acmeCertCacheDir, 0700); err != nil { | ||
| return fmt.Errorf("Failed to create cache directory: %w", err) |
There was a problem hiding this comment.
Is it not still helpful to create the cache directory if necessary?
There was a problem hiding this comment.
I noticed that this code is redundant. The cache implementation that we're using creates the directory if it doesn't exist yet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #35.