Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Disable password autofill upon page load #419

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Disable password autofill upon page load #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions atom/browser/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ source_set("browser") {
"//components/security_state/content",
"//components/security_state/core",
"//components/autofill/content/browser:browser",
"//components/password_manager/core/common",
"//third_party/protobuf:protobuf_lite",
"//third_party/WebKit/public:blink_headers",
]
Expand Down
8 changes: 8 additions & 0 deletions atom/browser/atom_browser_main_parts.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_result_codes.h"
#include "chrome/common/chrome_switches.h"
#include "components/password_manager/core/common/password_manager_features.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there already a dep for this in the target for atom_browser_main_parts.cc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it will fail to find the definition if I remove the header

#include "components/prefs/json_pref_store.h"
#include "components/prefs/pref_service.h"
#include "content/public/browser/browser_thread.h"
Expand Down Expand Up @@ -378,6 +379,13 @@ void AtomBrowserMainParts::PreMainMessageLoopRun() {
feature_list->RegisterFieldTrialOverride(
features::kGuestViewCrossProcessFrames.name,
base::FeatureList::OVERRIDE_DISABLE_FEATURE, field_trial);

// enable fill-on-account-select
field_trial = feature_list->GetFieldTrial(
password_manager::features::kFillOnAccountSelect);
feature_list->RegisterFieldTrialOverride(
password_manager::features::kFillOnAccountSelect.name,
base::FeatureList::OVERRIDE_ENABLE_FEATURE, field_trial);
}


Expand Down