only set the user agent override if we are overriding the user agent

auditors @bbondy
brave · Dec 29, 2016 · 0d2d46f · 0d2d46f
1 parent b3b9896
commit 0d2d46f
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/atom/browser/api/atom_api_web_contents.cc b/atom/browser/api/atom_api_web_contents.cc
@@ -1117,16 +1117,18 @@ void WebContents::LoadURL(const GURL& url, const mate::Dictionary& options) {
                                         blink::WebReferrerPolicyDefault);
 
   std::string user_agent;
-  if (options.Get("userAgent", &user_agent))
+  if (options.Get("userAgent", &user_agent)) {
     web_contents()->SetUserAgentOverride(user_agent);
+    params.override_user_agent =
+        content::NavigationController::UA_OVERRIDE_TRUE;
+  }
 
   std::string extra_headers;
   if (options.Get("extraHeaders", &extra_headers))
     params.extra_headers = extra_headers;
 
   web_contents()->UserGestureDone();
   params.transition_type = ui::PAGE_TRANSITION_TYPED;
-  params.override_user_agent = content::NavigationController::UA_OVERRIDE_TRUE;
   web_contents()->GetController().LoadURLWithParams(params);
 }