Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog]: ensure dialog doesn't unnecessarily fill screen height #996

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlanBreck
Copy link
Collaborator

@AlanBreck AlanBreck commented Feb 21, 2025

For some reason, the dialog viewed on ipads tries to take up the entire screen.

before after
Simulator Screenshot - iPad (10th generation) - 2025-02-21 at 16 22 16 Simulator Screenshot - iPad (10th generation) - 2025-02-21 at 16 22 35

Copy link
Contributor

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://996.pr.nala.bravesoftware.com/
✅ Commit preview: https://996.pr.nala.bravesoftware.com/commit-7e6ac33d40aba8fb0a65d589c95dca9087ea8807/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 119686 bytes
+ ./tokens/css/variables.css: 119686 bytes
Variables Diff: variables-android.diff
--- ./tokens/css/variables-android.old.css	2025-02-21 21:25:50.344604008 +0000
+++ ./tokens/css/variables-android.css	2025-02-21 21:25:10.460380712 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Feb 20 2025 22:35:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Feb 21 2025 21:25:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff
--- ./tokens/css/variables-browser.old.css	2025-02-21 21:25:50.692605903 +0000
+++ ./tokens/css/variables-browser.css	2025-02-21 21:25:10.437380577 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Feb 20 2025 22:35:20 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Feb 21 2025 21:25:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff
--- ./tokens/css/variables-ios.old.css	2025-02-21 21:25:50.944607276 +0000
+++ ./tokens/css/variables-ios.css	2025-02-21 21:25:10.482380842 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Feb 20 2025 22:35:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Feb 21 2025 21:25:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff
--- ./tokens/css/variables-marketing.old.css	2025-02-21 21:25:51.181608568 +0000
+++ ./tokens/css/variables-marketing.css	2025-02-21 21:25:10.507380989 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Feb 20 2025 22:35:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Feb 21 2025 21:25:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff
--- ./tokens/css/variables-news.old.css	2025-02-21 21:25:51.389609700 +0000
+++ ./tokens/css/variables-news.css	2025-02-21 21:25:10.537381166 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Feb 20 2025 22:35:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Feb 21 2025 21:25:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff
--- ./tokens/css/variables-newtab.old.css	2025-02-21 21:25:51.605610877 +0000
+++ ./tokens/css/variables-newtab.css	2025-02-21 21:25:10.548381231 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Feb 20 2025 22:35:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Feb 21 2025 21:25:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff
--- ./tokens/css/variables-search.old.css	2025-02-21 21:25:51.818612038 +0000
+++ ./tokens/css/variables-search.css	2025-02-21 21:25:10.529381119 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Feb 20 2025 22:35:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Feb 21 2025 21:25:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff
--- ./tokens/css/variables-web3.old.css	2025-02-21 21:25:52.049613296 +0000
+++ ./tokens/css/variables-web3.css	2025-02-21 21:25:10.555381272 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Feb 20 2025 22:35:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Feb 21 2025 21:25:10 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff
--- ./tokens/css/variables.old.css	2025-02-21 21:25:52.377615082 +0000
+++ ./tokens/css/variables.css	2025-02-21 21:25:10.285379681 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Feb 20 2025 22:35:20 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Feb 21 2025 21:25:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly, I'm seeing a difference compared to main branch when putting test content in the dialog - the line-height is different. But it doesn't seem related.

@aguscruiz
Copy link
Collaborator

aguscruiz commented Feb 21, 2025

It looks ok now on my iPad but unlike your screenshot, I seem to be getting an outline around it, maybe it's being forced into a focus state that it shouldn't have?

PS: Don't judge me on the other tab, it was for creating appstore images for Search lol.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants