[Deps]: Override to latest version of serialize-js (no patched version of rollup-plugin-terser) #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for Submitting! This PR is available for preview at the link below. ✅ PR tip preview: https://995.pr.nala.bravesoftware.com/ - ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 119686 bytes
+ ./tokens/css/variables.css: 119686 bytes
Variables Diff: variables-android.diff--- ./tokens/css/variables-android.old.css 2025-02-19 19:21:27.058025378 +0000
+++ ./tokens/css/variables-android.css 2025-02-19 19:20:45.881037028 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:23 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:20:45 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-browser.diff--- ./tokens/css/variables-browser.old.css 2025-02-19 19:21:27.307025340 +0000
+++ ./tokens/css/variables-browser.css 2025-02-19 19:20:45.861037011 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:23 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:20:45 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-ios.diff--- ./tokens/css/variables-ios.old.css 2025-02-19 19:21:27.507025308 +0000
+++ ./tokens/css/variables-ios.css 2025-02-19 19:20:45.899037042 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:20:45 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-marketing.diff--- ./tokens/css/variables-marketing.old.css 2025-02-19 19:21:27.722025276 +0000
+++ ./tokens/css/variables-marketing.css 2025-02-19 19:20:45.928037066 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:20:45 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-news.diff--- ./tokens/css/variables-news.old.css 2025-02-19 19:21:27.934025241 +0000
+++ ./tokens/css/variables-news.css 2025-02-19 19:20:45.958037091 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:20:45 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-newtab.diff--- ./tokens/css/variables-newtab.old.css 2025-02-19 19:21:28.137025212 +0000
+++ ./tokens/css/variables-newtab.css 2025-02-19 19:20:45.969037100 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:20:45 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-search.diff--- ./tokens/css/variables-search.old.css 2025-02-19 19:21:28.347025181 +0000
+++ ./tokens/css/variables-search.css 2025-02-19 19:20:45.950037084 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:20:45 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-web3.diff--- ./tokens/css/variables-web3.old.css 2025-02-19 19:21:28.740025118 +0000
+++ ./tokens/css/variables-web3.css 2025-02-19 19:20:45.976037105 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:20:45 GMT+0000 (Coordinated Universal Time)
*/
@media (prefers-color-scheme: light) {
Variables Diff: variables.diff--- ./tokens/css/variables.old.css 2025-02-19 19:21:29.097025065 +0000
+++ ./tokens/css/variables.css 2025-02-19 19:20:45.711036888 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:23 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:20:45 GMT+0000 (Coordinated Universal Time)
*/
:root {
|
AlanBreck
reviewed
Feb 19, 2025
diracdeltas
reviewed
Feb 19, 2025
…lup-plugin-terser
dd24a23 to
4ba4599
Compare
|
Nice catch both of you - I think I must've made my change on one branch and then changed branch and saved the version of the file open in my editor 😨 |
|
👋 Thanks for Submitting! This PR is available for preview at the link below. ✅ PR tip preview: https://995.pr.nala.bravesoftware.com/ - ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 119686 bytes
+ ./tokens/css/variables.css: 119686 bytes
Variables Diff: variables-android.diff--- ./tokens/css/variables-android.old.css 2025-02-19 19:52:08.532876204 +0000
+++ ./tokens/css/variables-android.css 2025-02-19 19:51:29.703935048 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:23 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:51:29 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-browser.diff--- ./tokens/css/variables-browser.old.css 2025-02-19 19:52:08.841875754 +0000
+++ ./tokens/css/variables-browser.css 2025-02-19 19:51:29.684935040 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:23 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:51:29 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-ios.diff--- ./tokens/css/variables-ios.old.css 2025-02-19 19:52:09.135875324 +0000
+++ ./tokens/css/variables-ios.css 2025-02-19 19:51:29.721935057 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:51:29 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-marketing.diff--- ./tokens/css/variables-marketing.old.css 2025-02-19 19:52:09.422874906 +0000
+++ ./tokens/css/variables-marketing.css 2025-02-19 19:51:29.749935070 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:51:29 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-news.diff--- ./tokens/css/variables-news.old.css 2025-02-19 19:52:09.560874706 +0000
+++ ./tokens/css/variables-news.css 2025-02-19 19:51:29.778935084 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:51:29 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-newtab.diff--- ./tokens/css/variables-newtab.old.css 2025-02-19 19:52:09.864874263 +0000
+++ ./tokens/css/variables-newtab.css 2025-02-19 19:51:29.788935088 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:51:29 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-search.diff--- ./tokens/css/variables-search.old.css 2025-02-19 19:52:10.174873812 +0000
+++ ./tokens/css/variables-search.css 2025-02-19 19:51:29.771935080 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:51:29 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-web3.diff--- ./tokens/css/variables-web3.old.css 2025-02-19 19:52:10.472873378 +0000
+++ ./tokens/css/variables-web3.css 2025-02-19 19:51:29.795935091 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:51:29 GMT+0000 (Coordinated Universal Time)
*/
@media (prefers-color-scheme: light) {
Variables Diff: variables.diff--- ./tokens/css/variables.old.css 2025-02-19 19:52:10.899872751 +0000
+++ ./tokens/css/variables.css 2025-02-19 19:51:29.536934971 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 19 2025 10:58:23 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 19 2025 19:51:29 GMT+0000 (Coordinated Universal Time)
*/
:root {
|
diracdeltas
requested changes
Feb 19, 2025
There was a problem hiding this comment.
actually we don't use serialize-javascript in this package-lock.json. the dependabot alert is for examples/example-ui-react/package-lock.json. we can either ignore it as a false positive (if it's just used for an example) or fix in that directory.
|
🤦 Okay, let's ignore it, that's just an example project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.