[Navigation]: Add animations when changing between active nav items #854

fallaciousreasoning · 2024-10-02T03:10:53Z

I've used anchor-positioning for the animations, so they work without any JS. Because its a fairly new API I've left in a fallback with no animations.

github-actions · 2024-10-02T03:13:43Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://854.pr.nala.bravesoftware.com/
✅ Commit preview: https://854.pr.nala.bravesoftware.com/commit-9c8d86077d57b08027e2a25c0f2d17ff2545ec29/

- ./tokens/css/variables-android.old.css: 7424 bytes
+ ./tokens/css/variables-android.css: 7424 bytes
---
- ./tokens/css/variables-browser.old.css: 6874 bytes
+ ./tokens/css/variables-browser.css: 6874 bytes
---
- ./tokens/css/variables-ios.old.css: 7067 bytes
+ ./tokens/css/variables-ios.css: 7067 bytes
---
- ./tokens/css/variables-marketing.old.css: 13561 bytes
+ ./tokens/css/variables-marketing.css: 13561 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1941 bytes
+ ./tokens/css/variables-newtab.css: 1941 bytes
---
- ./tokens/css/variables-search.old.css: 2419 bytes
+ ./tokens/css/variables-search.css: 2419 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 114834 bytes
+ ./tokens/css/variables.css: 114834 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-10-02 03:12:12.585139025 +0000
+++ ./tokens/css/variables-android.css	2024-10-02 03:11:31.333991861 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 03:11:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-10-02 03:12:12.930140320 +0000
+++ ./tokens/css/variables-browser.css	2024-10-02 03:11:31.314991792 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 03:11:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-10-02 03:12:13.257141552 +0000
+++ ./tokens/css/variables-ios.css	2024-10-02 03:11:31.355991942 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 03:11:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-10-02 03:12:13.591142811 +0000
+++ ./tokens/css/variables-marketing.css	2024-10-02 03:11:31.380992033 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 03:11:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-10-02 03:12:13.925144071 +0000
+++ ./tokens/css/variables-news.css	2024-10-02 03:11:31.406992129 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 03:11:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-10-02 03:12:14.293145460 +0000
+++ ./tokens/css/variables-newtab.css	2024-10-02 03:11:31.415992162 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 03:11:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-10-02 03:12:14.629146728 +0000
+++ ./tokens/css/variables-search.css	2024-10-02 03:11:31.400992107 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 03:11:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-10-02 03:12:14.774147277 +0000
+++ ./tokens/css/variables-web3.css	2024-10-02 03:11:31.422992187 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 03:11:31 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-10-02 03:12:15.223148971 +0000
+++ ./tokens/css/variables.css	2024-10-02 03:11:31.168991257 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 03:11:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

examples/plain-html/index.html

fallaciousreasoning · 2024-10-04T01:08:04Z

@aguscruiz said my change to the highlight on nested menus should be fine 😄

AlanBreck · 2024-10-15T22:36:05Z

@aguscruiz said my change to the highlight on nested menus should be fine 😄

@fallaciousreasoning, are you referring to this?

src/components/navigation/navigation.svelte

github-actions · 2024-10-16T02:01:19Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://854.pr.nala.bravesoftware.com/
✅ Commit preview: https://854.pr.nala.bravesoftware.com/commit-9ca6847d11aa5cedd3456babf45a452db11e43e0/

- ./tokens/css/variables-android.old.css: 7424 bytes
+ ./tokens/css/variables-android.css: 7424 bytes
---
- ./tokens/css/variables-browser.old.css: 6874 bytes
+ ./tokens/css/variables-browser.css: 6874 bytes
---
- ./tokens/css/variables-ios.old.css: 7067 bytes
+ ./tokens/css/variables-ios.css: 7067 bytes
---
- ./tokens/css/variables-marketing.old.css: 13561 bytes
+ ./tokens/css/variables-marketing.css: 13561 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1941 bytes
+ ./tokens/css/variables-newtab.css: 1941 bytes
---
- ./tokens/css/variables-search.old.css: 2419 bytes
+ ./tokens/css/variables-search.css: 2419 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 115505 bytes
+ ./tokens/css/variables.css: 115505 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-10-16 01:59:47.414948350 +0000
+++ ./tokens/css/variables-android.css	2024-10-16 01:59:09.978826930 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 01:59:09 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-10-16 01:59:47.694949337 +0000
+++ ./tokens/css/variables-browser.css	2024-10-16 01:59:09.938826771 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 01:59:09 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-10-16 01:59:47.974950327 +0000
+++ ./tokens/css/variables-ios.css	2024-10-16 01:59:09.998827010 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 01:59:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-10-16 01:59:48.242951271 +0000
+++ ./tokens/css/variables-marketing.css	2024-10-16 01:59:10.026827122 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 01:59:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-10-16 01:59:48.550952360 +0000
+++ ./tokens/css/variables-news.css	2024-10-16 01:59:10.054827234 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 01:59:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-10-16 01:59:48.858953453 +0000
+++ ./tokens/css/variables-newtab.css	2024-10-16 01:59:10.062827265 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 01:59:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-10-16 01:59:49.122954382 +0000
+++ ./tokens/css/variables-search.css	2024-10-16 01:59:10.046827202 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 01:59:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-10-16 01:59:49.422955439 +0000
+++ ./tokens/css/variables-web3.css	2024-10-16 01:59:10.066827282 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 01:59:10 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-10-16 01:59:49.814956828 +0000
+++ ./tokens/css/variables.css	2024-10-16 01:59:09.774826117 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 01:59:09 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

examples/plain-html/index.html

github-actions · 2024-10-16T02:07:51Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://854.pr.nala.bravesoftware.com/
✅ Commit preview: https://854.pr.nala.bravesoftware.com/commit-7fd7553b85c2ff3cdea3a443f5925ae867275d0c/

- ./tokens/css/variables-android.old.css: 7424 bytes
+ ./tokens/css/variables-android.css: 7424 bytes
---
- ./tokens/css/variables-browser.old.css: 6874 bytes
+ ./tokens/css/variables-browser.css: 6874 bytes
---
- ./tokens/css/variables-ios.old.css: 7067 bytes
+ ./tokens/css/variables-ios.css: 7067 bytes
---
- ./tokens/css/variables-marketing.old.css: 13561 bytes
+ ./tokens/css/variables-marketing.css: 13561 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1941 bytes
+ ./tokens/css/variables-newtab.css: 1941 bytes
---
- ./tokens/css/variables-search.old.css: 2419 bytes
+ ./tokens/css/variables-search.css: 2419 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 115505 bytes
+ ./tokens/css/variables.css: 115505 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-10-16 02:06:21.932059454 +0000
+++ ./tokens/css/variables-android.css	2024-10-16 02:05:42.240001436 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 02:05:42 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-10-16 02:06:22.128059302 +0000
+++ ./tokens/css/variables-browser.css	2024-10-16 02:05:42.224001402 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 02:05:42 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-10-16 02:06:22.336059136 +0000
+++ ./tokens/css/variables-ios.css	2024-10-16 02:05:42.256001471 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 02:05:42 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-10-16 02:06:22.528058987 +0000
+++ ./tokens/css/variables-marketing.css	2024-10-16 02:05:42.284001530 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 02:05:42 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-10-16 02:06:22.704058849 +0000
+++ ./tokens/css/variables-news.css	2024-10-16 02:05:42.312001589 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 02:05:42 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-10-16 02:06:23.036058584 +0000
+++ ./tokens/css/variables-newtab.css	2024-10-16 02:05:42.320001606 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 02:05:42 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-10-16 02:06:23.248058420 +0000
+++ ./tokens/css/variables-search.css	2024-10-16 02:05:42.304001572 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 02:05:42 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-10-16 02:06:23.484058230 +0000
+++ ./tokens/css/variables-web3.css	2024-10-16 02:05:42.328001623 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 02:05:42 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-10-16 02:06:23.856058612 +0000
+++ ./tokens/css/variables.css	2024-10-16 02:05:42.076001088 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Oct 16 2024 00:44:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 16 2024 02:05:42 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

fallaciousreasoning · 2024-10-16T02:17:41Z

@fallaciousreasoning, are you referring to this?

yup

AlanBreck

Looks good!

src/components/navigation/navigation.svelte

fallaciousreasoning · 2024-10-18T00:36:36Z

@AlanBreck I'm going to merge this as-is, but I'll have a look at using the viewTransitions api when I get a chance

github-actions · 2024-10-18T00:39:02Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://854.pr.nala.bravesoftware.com/
✅ Commit preview: https://854.pr.nala.bravesoftware.com/commit-85cec0175b5d91577dfa43870d5d8501c14cc876/

- ./tokens/css/variables-android.old.css: 7424 bytes
+ ./tokens/css/variables-android.css: 7424 bytes
---
- ./tokens/css/variables-browser.old.css: 6874 bytes
+ ./tokens/css/variables-browser.css: 6874 bytes
---
- ./tokens/css/variables-ios.old.css: 7067 bytes
+ ./tokens/css/variables-ios.css: 7067 bytes
---
- ./tokens/css/variables-marketing.old.css: 13561 bytes
+ ./tokens/css/variables-marketing.css: 13561 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1941 bytes
+ ./tokens/css/variables-newtab.css: 1941 bytes
---
- ./tokens/css/variables-search.old.css: 2419 bytes
+ ./tokens/css/variables-search.css: 2419 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 119572 bytes
+ ./tokens/css/variables.css: 119572 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-10-18 00:37:22.407227876 +0000
+++ ./tokens/css/variables-android.css	2024-10-18 00:36:44.698885909 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Oct 17 2024 21:57:38 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Oct 18 2024 00:36:44 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-10-18 00:37:22.847231687 +0000
+++ ./tokens/css/variables-browser.css	2024-10-18 00:36:44.682885766 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Oct 17 2024 21:57:38 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Oct 18 2024 00:36:44 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-10-18 00:37:23.259235256 +0000
+++ ./tokens/css/variables-ios.css	2024-10-18 00:36:44.714886054 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Oct 17 2024 21:57:38 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Oct 18 2024 00:36:44 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-10-18 00:37:23.663238759 +0000
+++ ./tokens/css/variables-marketing.css	2024-10-18 00:36:44.734886235 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Oct 17 2024 21:57:38 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Oct 18 2024 00:36:44 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-10-18 00:37:24.103242566 +0000
+++ ./tokens/css/variables-news.css	2024-10-18 00:36:44.762886488 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Oct 17 2024 21:57:38 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Oct 18 2024 00:36:44 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-10-18 00:37:24.523245689 +0000
+++ ./tokens/css/variables-newtab.css	2024-10-18 00:36:44.770886559 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Oct 17 2024 21:57:38 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Oct 18 2024 00:36:44 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-10-18 00:37:25.051249588 +0000
+++ ./tokens/css/variables-search.css	2024-10-18 00:36:44.754886415 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Oct 17 2024 21:57:38 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Oct 18 2024 00:36:44 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-10-18 00:37:25.447252504 +0000
+++ ./tokens/css/variables-web3.css	2024-10-18 00:36:44.774886596 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Oct 17 2024 21:57:38 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Oct 18 2024 00:36:44 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-10-18 00:37:26.059257026 +0000
+++ ./tokens/css/variables.css	2024-10-18 00:36:44.502884140 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Oct 17 2024 21:57:38 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Oct 18 2024 00:36:44 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

kdenhartog · 2024-10-18T00:50:04Z

Took a look at this and it's not an issue see here: #854 (comment)

removing the label

fallaciousreasoning added 6 commits October 2, 2024 14:09

Add animations

e7dbcc0

Cleanup

6c54c95

Add fallback for when anchor positioning isn't supported (i.e. firefox)

2b377a3

Fix example

35755b1

Get working with web components

b6f1424

Make plain html example work

9c8d860

fallaciousreasoning requested review from petemill and AlanBreck as code owners October 2, 2024 03:10

github-actions bot reviewed Oct 2, 2024

View reviewed changes

examples/plain-html/index.html Show resolved Hide resolved

github-actions bot added the needs-security-review label Oct 2, 2024

github-actions bot assigned thypon Oct 2, 2024

AlanBreck reviewed Oct 15, 2024

View reviewed changes

src/components/navigation/navigation.svelte Outdated Show resolved Hide resolved

github-actions bot reviewed Oct 16, 2024

View reviewed changes

examples/plain-html/index.html Show resolved Hide resolved

github-actions bot assigned kdenhartog Oct 16, 2024

fallaciousreasoning force-pushed the navigation-item-animate branch from 9ca6847 to 7fd7553 Compare October 16, 2024 02:05

fallaciousreasoning requested a review from AlanBreck October 16, 2024 02:18

AlanBreck approved these changes Oct 17, 2024

View reviewed changes

src/components/navigation/navigation.svelte Outdated Show resolved Hide resolved

Move fallback into the same place

85cec01

fallaciousreasoning force-pushed the navigation-item-animate branch from 7fd7553 to 85cec01 Compare October 18, 2024 00:36

fallaciousreasoning enabled auto-merge (squash) October 18, 2024 00:36

fallaciousreasoning merged commit 481d25d into main Oct 18, 2024
6 checks passed

fallaciousreasoning deleted the navigation-item-animate branch October 18, 2024 00:38

kdenhartog removed the needs-security-review label Oct 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Navigation]: Add animations when changing between active nav items #854

[Navigation]: Add animations when changing between active nav items #854

fallaciousreasoning commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

fallaciousreasoning commented Oct 4, 2024

AlanBreck commented Oct 15, 2024

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

fallaciousreasoning commented Oct 16, 2024

AlanBreck left a comment

fallaciousreasoning commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

kdenhartog commented Oct 18, 2024

[Navigation]: Add animations when changing between active nav items #854

[Navigation]: Add animations when changing between active nav items #854

Conversation

fallaciousreasoning commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

fallaciousreasoning commented Oct 4, 2024

AlanBreck commented Oct 15, 2024

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

fallaciousreasoning commented Oct 16, 2024

AlanBreck left a comment

Choose a reason for hiding this comment

fallaciousreasoning commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

kdenhartog commented Oct 18, 2024