Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation]: Don't show list bullet points #849

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

fallaciousreasoning
Copy link
Collaborator

@fallaciousreasoning fallaciousreasoning commented Oct 2, 2024

Currently, if you render a NavigationItem directly inside a Navigation, it will show character which is not really what we want.

helps with #847

Copy link
Contributor

github-actions bot commented Oct 2, 2024

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://849.pr.nala.bravesoftware.com/
✅ Commit preview: https://849.pr.nala.bravesoftware.com/commit-0b89602fd8fc7e1ca7d360461c2b39881c091890/

- ./tokens/css/variables-android.old.css: 7424 bytes
+ ./tokens/css/variables-android.css: 7424 bytes
---
- ./tokens/css/variables-browser.old.css: 6874 bytes
+ ./tokens/css/variables-browser.css: 6874 bytes
---
- ./tokens/css/variables-ios.old.css: 7067 bytes
+ ./tokens/css/variables-ios.css: 7067 bytes
---
- ./tokens/css/variables-marketing.old.css: 13561 bytes
+ ./tokens/css/variables-marketing.css: 13561 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1941 bytes
+ ./tokens/css/variables-newtab.css: 1941 bytes
---
- ./tokens/css/variables-search.old.css: 2419 bytes
+ ./tokens/css/variables-search.css: 2419 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 114834 bytes
+ ./tokens/css/variables.css: 114834 bytes
Variables Diff: variables-android.diff
--- ./tokens/css/variables-android.old.css	2024-10-02 00:15:47.616701039 +0000
+++ ./tokens/css/variables-android.css	2024-10-02 00:15:08.398685680 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 00:15:08 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff
--- ./tokens/css/variables-browser.old.css	2024-10-02 00:15:48.016701179 +0000
+++ ./tokens/css/variables-browser.css	2024-10-02 00:15:08.381685690 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 00:15:08 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff
--- ./tokens/css/variables-ios.old.css	2024-10-02 00:15:48.356701294 +0000
+++ ./tokens/css/variables-ios.css	2024-10-02 00:15:08.415685670 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 00:15:08 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff
--- ./tokens/css/variables-marketing.old.css	2024-10-02 00:15:48.693701413 +0000
+++ ./tokens/css/variables-marketing.css	2024-10-02 00:15:08.439685656 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 00:15:08 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff
--- ./tokens/css/variables-news.old.css	2024-10-02 00:15:49.054701541 +0000
+++ ./tokens/css/variables-news.css	2024-10-02 00:15:08.464685641 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 00:15:08 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff
--- ./tokens/css/variables-newtab.old.css	2024-10-02 00:15:49.400701661 +0000
+++ ./tokens/css/variables-newtab.css	2024-10-02 00:15:08.472685637 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 00:15:08 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff
--- ./tokens/css/variables-search.old.css	2024-10-02 00:15:49.750701787 +0000
+++ ./tokens/css/variables-search.css	2024-10-02 00:15:08.458685645 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 00:15:08 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff
--- ./tokens/css/variables-web3.old.css	2024-10-02 00:15:50.147701924 +0000
+++ ./tokens/css/variables-web3.css	2024-10-02 00:15:08.478685633 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 00:15:08 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff
--- ./tokens/css/variables.old.css	2024-10-02 00:15:50.683702111 +0000
+++ ./tokens/css/variables.css	2024-10-02 00:15:08.240685773 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sun Sep 29 2024 19:55:24 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Oct 02 2024 00:15:08 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

@fallaciousreasoning fallaciousreasoning merged commit 239ad8e into main Oct 10, 2024
5 checks passed
@fallaciousreasoning fallaciousreasoning deleted the navigation-item-style branch October 10, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants