This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Comment unused require for rimraf to fix missing module error #9919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This was blocking builds after a clean install Fix #9918
|
I had this same error again so I'm going ahead and merge. This has no impact and only left commented a package we don't require anymore. Please ping me if there's something wrong and I'll revert and investigate. thanks. |
|
also moving to 0.21.x |
|
++ |
|
@cezaraugusto please add this disabled tests onto this list #5389. Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was blocking builds after a clean install.
Fix #9918
This also happens from 0.17.x to master, but given the feature is not enabled anymore, error in dist build is silent.
Error exists because "exclude extension" option was calling
rimrafas a global dep but at some point we removed it. Given we can't exclude an extension via extensions panel anymore, this became a leftover and requiring a missing module was stopping build from running.STR: