Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

only send ipc messages to the hostWebContents of the tab that generat… #9702

Merged
merged 1 commit into from
Jun 30, 2017
Merged

only send ipc messages to the hostWebContents of the tab that generat… #9702

merged 1 commit into from
Jun 30, 2017

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Jun 25, 2017 •
edited by bsclifton
Loading

…ed them

fix #9701

Test Plan:

  1. Go to slashdot.org
  2. Verify ads/trackers blocked on shields menu

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bridiver bridiver added the perf label Jun 25, 2017
@bridiver bridiver added this to the 0.18.x (Developer Channel) milestone Jun 25, 2017
@bridiver bridiver self-assigned this Jun 25, 2017
@bridiver bridiver requested review from bbondy and NejcZdovc June 25, 2017 05:58
@bridiver bridiver mentioned this pull request Jun 25, 2017
Merged
8 tasks
@bridiver bridiver mentioned this pull request Jun 25, 2017
Closed
@bridiver bridiver requested a review from bsclifton June 29, 2017 17:45
@NejcZdovc NejcZdovc mentioned this pull request Jun 29, 2017
Closed
8 tasks
bsclifton
bsclifton approved these changes Jun 30, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 ++

@bsclifton bsclifton merged commit 8fde201 into master Jun 30, 2017
@bsclifton bsclifton deleted the issue-9701 branch June 30, 2017 17:40
bsclifton added a commit that referenced this pull request Jun 30, 2017
@bsclifton
Merge pull request #9702 from brave/issue-9701
e36fe3a 
only send ipc messages to the hostWebContents of the tab that generat…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@NejcZdovc NejcZdovc Awaiting requested review from NejcZdovc

Assignees

@bridiver bridiver

Labels
perf QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging this pull request may close these issues.

don't send messages to all windows in onBeforeRequest
2 participants
@bridiver @bsclifton