-
Notifications
You must be signed in to change notification settings - Fork 971
Tweak tabtitle threshold w/ secondary icons on small tabs #9512
Conversation
Auditors: @bsclifton Close #9466 Test Plan: covered by automated tests
@cezaraugusto this is ready for review, right? |
@@ -152,7 +152,8 @@ const tabContentState = { | |||
// If closeIcon is fixed then there's no room for another icon | |||
!tabContentState.hasFixedCloseIcon(state, frameKey) && | |||
// completely hide it for small sizes | |||
!hasBreakpoint(frame.get('breakpoint'), ['mediumSmall', 'small', 'extraSmall', 'smallest']) | |||
!hasBreakpoint(frame.get('breakpoint'), | |||
['medium', 'mediumSmall', 'small', 'extraSmall', 'smallest']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checkout my PR that refactored this function and I see that medium
was not there before either. How come that we need to add it now? Was this working correctly before in previous versions or never?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the feature works as expected but turns out to have bad UI. It wasn't introduced in your PR.
@bsclifton yes ready. It wasn't a bug before and wasn't a regression as well but given the bad look and feel this tweak is needed. I'll label needs QA to double-check as well, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing and changes look good 👍
Not sure if this is part of this PR or not (if not let's create a issue for it), but I think that it would be good to fix this one as well. Open some empty new session tabs and try to resize. I think that we should display session icon with a number if there is no fav icon and not an empty space as we do for a regular new tab. |
Tweak tabtitle threshold w/ secondary icons on small tabs
Tweak tabtitle threshold w/ secondary icons on small tabs
@NejcZdovc re #9512 (comment) I would go adding paper icon instead. It is the default for websites with broken favicons. Maybe just left the title, but I prefer the former. Anyway, your assumption is valid given empty tab is not pleasing. /cc @bradleyrichter for the rescue |
Submitter Checklist:
git rebase -i
to squash commits (if needed).Auditors: @bsclifton
Close #9466
Test Plan:
covered by automated tests
Manual Test:
Reviewer Checklist: