Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Fix problems with file:/// URLs #8969

Merged
merged 2 commits into from
May 20, 2017
Merged

Fix problems with file:/// URLs #8969

merged 2 commits into from
May 20, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented May 20, 2017

fix #8967, fix #8947

test plan:

  1. automated unittest and noscript test should pass
  2. disable scripts globally. open test/fixtures/noscript2.html as a file:// URL in brave
  3. open a new tab and type 'fi'. there should be no console errors.
  4. in the file:// tab, click the noscript icon and 'allow until restart'
  5. in a new tab, go to nytimes.com. you should see that scripts are blocked.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@diracdeltas diracdeltas added this to the 0.15.300 milestone May 20, 2017
@diracdeltas diracdeltas self-assigned this May 20, 2017
@diracdeltas diracdeltas requested a review from bbondy May 20, 2017 01:08
@bbondy
Copy link
Member

bbondy commented May 20, 2017

wow both problems with file:///
Thanks for the fixes. 💯

@bbondy bbondy merged commit a42eeac into master May 20, 2017
bbondy added a commit that referenced this pull request May 20, 2017
Fix problems with file:/// URLs
@bsclifton bsclifton deleted the fix/noscript-file branch May 22, 2017 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants