This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
allow PDFJS to load local files #8645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #2714 test plan: 1. start Brave with PDFJS enabled and browse to a local PDF file. it should display correctly. the urlbar should show the 'file:' location. 2. turn off PDFJS and go to the file. it should prompt to download.
diracdeltas
commented
May 3, 2017
| @@ -400,6 +400,9 @@ module.exports.init = () => { | |||
| } | |||
|
|
|||
| let loadExtension = (extensionId, extensionPath, manifest = {}, manifestLocation = 'unpacked') => { | |||
| if (extensionId === config.PDFJSExtensionId) { | |||
| manifestLocation = 'component' | |||
There was a problem hiding this comment.
Note: 'component' type extensions are able to access cross-origin 'file:' URLs, but somehow they are not able to see 'file:' URLs in the chrome.webRequest listener; instead the 'file:' URL webrequest listener must be added using session.webRequest.
|
It would be interesting to dig into chrome.webRequest more, but this is ok for now. Nice to have it working, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2714
test plan:
git rebase -ito squash commits (if needed).Test Plan: