This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -145,7 +145,10 @@ class UrlBar extends ImmutableComponent { | |||
} | |||
|
|||
componentWillMount () { | |||
ipc.on(messages.SHORTCUT_FOCUS_URL, this.onFocus.bind(this)) | |||
ipc.on(messages.SHORTCUT_FOCUS_URL, () => { | |||
this.onFocus.bind(this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, this is wrong and causing test failures. Will fix!
cc @bridiver since tests seem to be failing inconsistently. travis reports:
Locally when I run |
* @param {Array} message message and arguments to send | ||
* @return {boolean} whether the message was sent | ||
*/ | ||
const sendToFocusedWindow = (focusedWindow, message) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I've been wanting to do this, so much cleaner.
Thanks, feel free to merge. |
Merging for now despite Travis since I have another branch that depends on this. |
diracdeltas
added a commit
that referenced
this pull request
Dec 23, 2015
More app menu work-in-progress
np, thanks. |
This was referenced Jan 27, 2022
This was referenced Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started to conflict with the windowstore/appstore changes, so I'm opening it now.
Auditors: @bbondy