This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Adds non-verified option to the payment page #8394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrose17
suggested changes
Apr 19, 2017
|
@mrose17, these PR is not yet completed, still have work-in-progress label |
e4be1d3 to
229de66
Compare
229de66 to
3f83263
Compare
696ef4b to
798f177
Compare
bsclifton
reviewed
Apr 24, 2017
js/constants/appConfig.js
Outdated
| @@ -149,6 +149,7 @@ module.exports = { | |||
| 'bookmarks.toolbar.showOnlyFavicon': false, | |||
| 'payments.enabled': false, | |||
| 'payments.notifications': false, | |||
| 'payments.non-verified-publishers': true, | |||
There was a problem hiding this comment.
Could you update this to be more descriptive? Maybe payments.allow-non-verified-publishers?
bsclifton
reviewed
Apr 24, 2017
js/constants/settings.js
Outdated
| @@ -55,6 +55,7 @@ const settings = { | |||
| PAYMENTS_NOTIFICATION_RECONCILE_SOON_TIMESTAMP: 'notification-reconcile-soon-timestamp', | |||
| PAYMENTS_NOTIFICATION_TRY_PAYMENTS_DISMISSED: 'payments.notificationTryPaymentsDismissed', | |||
| PAYMENTS_CONTRIBUTION_AMOUNT: 'payments.contribution-amount', | |||
| PAYMENTS_NON_VERIFIED: 'payments.non-verified-publishers', | |||
Resolves brave#8231 Auditors: @mrose17 @bsclifton Test Plan: - go to payments page - click on advance settings - disabled option "Allow contributions to non-verified sites" - all non-verified sites should be hidden from a table
798f177 to
462d4aa
Compare
bsclifton
approved these changes
Apr 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Resolves #8231
Auditors: @mrose17 @bsclifton
Test Plan