Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Update privateTab text #8268

Merged
merged 2 commits into from
Apr 13, 2017
Merged

Update privateTab text #8268

merged 2 commits into from
Apr 13, 2017

Conversation

cezaraugusto
Copy link
Contributor

Test Plan:

  • Should match screenshot:

screen shot 2017-04-12 at 6 41 47 pm

@cezaraugusto cezaraugusto added design A design change, especially one which needs input from the design team. feature/newtab privacy labels Apr 12, 2017
@cezaraugusto cezaraugusto added this to the 0.14.2 milestone Apr 12, 2017
bradleyrichter
bradleyrichter approved these changes Apr 12, 2017
View reviewed changes
Copy link
Contributor

@bradleyrichter bradleyrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG for this release. Thanks!

@cezaraugusto cezaraugusto self-assigned this Apr 12, 2017
bsclifton
bsclifton approved these changes Apr 12, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated text to fix typo and ended up changing that sentence. @bradleyrichter what do you think?

Changes LGTM! 😄

bradleyrichter
bradleyrichter approved these changes Apr 13, 2017
View reviewed changes
Copy link
Contributor

@bradleyrichter bradleyrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@bsclifton bsclifton merged commit 2e65902 into brave:master Apr 13, 2017
@cezaraugusto cezaraugusto deleted the newtab/8267 branch July 25, 2017 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton

@bradleyrichter bradleyrichter

Assignees

@cezaraugusto cezaraugusto

Labels
design A design change, especially one which needs input from the design team. feature/newtab privacy QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cezaraugusto @bsclifton @bradleyrichter