Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix Pocket setting l10 #8110

Merged
merged 1 commit into from
Apr 7, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/extensions/brave/locales/en-US/preferences.properties
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ bookmarkToolbarShowFavicon=Favicons
bookmarkToolbarShowOnlyFavicon=Show only favicon
contentSettings=Content Settings
extensions=Extensions
enablePocket=Enable Pocket
enableExtension=Enable {{extensionName}}
enableVimium=Enable Vimium
moreExtensionsComingSoon=More extensions coming soon…
viewInstalledExtensions=View Installed Extensions…
Expand Down
1 change: 1 addition & 0 deletions app/renderer/components/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ class SettingCheckbox extends ImmutableComponent {
/>
<label className={labelClass}
data-l10n-id={this.props.dataL10nId}
data-l10n-args={this.props.dataL10nArgs}
htmlFor={this.props.prefKey}
/>
{this.props.options}
Expand Down
5 changes: 4 additions & 1 deletion js/about/preferences.js
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,9 @@ class SecurityTab extends ImmutableComponent {

class AdvancedTab extends ImmutableComponent {
render () {
const pocketL10nArgs = {
extensionName: 'Pocket'
}
return <div>
<div className='sectionTitle' data-l10n-id='contentSettings' />
<SettingsList>
Expand All @@ -666,7 +669,7 @@ class AdvancedTab extends ImmutableComponent {
<SettingsList>
<SettingCheckbox dataL10nId='usePDFJS' prefKey={settings.PDFJS_ENABLED} settings={this.props.settings} onChangeSetting={this.props.onChangeSetting} />
<SettingCheckbox dataL10nId='useTorrentViewer' prefKey={settings.TORRENT_VIEWER_ENABLED} settings={this.props.settings} onChangeSetting={this.props.onChangeSetting} />
<SettingCheckbox dataL10nId='enablePocket' prefKey={settings.POCKET_ENABLED} settings={this.props.settings} onChangeSetting={this.props.onChangeSetting} />
<SettingCheckbox dataL10nId='enableExtension' dataL10nArgs={JSON.stringify(pocketL10nArgs)} prefKey={settings.POCKET_ENABLED} settings={this.props.settings} onChangeSetting={this.props.onChangeSetting} />
<Button l10nId='viewInstalledExtensions' className='primaryButton viewExtensionsInfo'
onClick={aboutActions.newFrame.bind(null, {
location: 'about:extensions'
Expand Down