This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 971
Fixes usage of ledger advance settings in the ledger table #8066
Merged
diracdeltas
merged 1 commit into
brave:master
from
NejcZdovc:hotfix/#7987-ledger-eligible
Apr 5, 2017
Merged
Fixes usage of ledger advance settings in the ledger table #8066
diracdeltas
merged 1 commit into
brave:master
from
NejcZdovc:hotfix/#7987-ledger-eligible
Apr 5, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrose17
approved these changes
Apr 4, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
test plan worked, but some synopsis tests may be failing due to this: https://travis-ci.org/brave/browser-laptop/jobs/218608197#L3227. they failed locally for me too. |
specifically this fails on this branch but passes on master (locally):
|
Resolves brave#7987 Auditors: @mrose17 @diracdeltas Test Plan: - enable payments - visit site for at least 8 seconds or until it appears in the synopsis table - set minimum visits to 5 instead of 1 - site shouldn't be in the ledger table
d149ed3
to
77c499c
Compare
@diracdeltas fixed, I needed to add back one property, because it's used in |
lgtm, thanks for looking into this |
diracdeltas
approved these changes
Apr 5, 2017
NejcZdovc
added a commit
to NejcZdovc/ledger-publisher
that referenced
this pull request
Apr 5, 2017
NejcZdovc
added a commit
to NejcZdovc/ledger-publisher
that referenced
this pull request
Apr 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).Resolves #7987
Auditors
@mrose17 @diracdeltas
Test Plan