Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Improves badge-counter positioning #7978

Merged
merged 1 commit into from
Mar 31, 2017
Merged

Improves badge-counter positioning #7978

merged 1 commit into from
Mar 31, 2017

Conversation

jonathansampson
Copy link
Collaborator

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #7977

image
image
image

@jonathansampson jonathansampson added this to the 0.14.0 milestone Mar 30, 2017
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great on macOS 😄
screen shot 2017-03-29 at 11 08 03 pm

screen shot 2017-03-29 at 11 10 30 pm

@NejcZdovc
Copy link
Contributor

@clifton how about Windows?

@bsclifton bsclifton modified the milestones: 0.14.1, 0.14.0 Mar 30, 2017
@bsclifton
Copy link
Member

moved to 0.14.1; ubuntu needs some love:
screen shot 2017-03-30 at 12 20 20 am

- Unifies styles across macOS, Linux, and Windows.
@bsclifton
Copy link
Member

Reviewed updated version on Ubuntu 14 and macOS; looks great 👍

@bsclifton bsclifton added design A design change, especially one which needs input from the design team. feature/adblock polish Nice to have — usually related to front-end/visual tasks. release-notes/exclude labels Mar 30, 2017
@jonathansampson
Copy link
Collaborator Author

macOS, Linux, and Windows:

image image image

@bsclifton bsclifton requested a review from NejcZdovc March 30, 2017 18:46
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is happening with a font on Linux? We are using Arial Narrow, is this not supported in Linux? @bradleyrichter

@bsclifton bsclifton modified the milestones: 0.14.1, 0.14.2 Mar 31, 2017
@bsclifton
Copy link
Member

bsclifton commented Mar 31, 2017

Changes look great to me! @NejcZdovc, I created an issue to track the concern you had with the font on Ubuntu/Linux: #8007

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/adblock polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS release-notes/exclude
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants