This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
approved these changes
Mar 30, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clifton how about Windows? |
- Unifies styles across macOS, Linux, and Windows.
77ba9cd
to
97fcc4e
Compare
Reviewed updated version on Ubuntu 14 and macOS; looks great 👍 |
NejcZdovc
suggested changes
Mar 30, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is happening with a font on Linux? We are using Arial Narrow, is this not supported in Linux? @bradleyrichter
Changes look great to me! @NejcZdovc, I created an issue to track the concern you had with the font on Ubuntu/Linux: #8007 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
design
A design change, especially one which needs input from the design team.
feature/adblock
polish
Nice to have — usually related to front-end/visual tasks.
QA/checked-Linux
QA/checked-macOS
release-notes/exclude
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).Fixes #7977