Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

block media device enumeration when fingerprinting protection is on #7871

Merged
merged 1 commit into from
Apr 3, 2017
Merged

block media device enumeration when fingerprinting protection is on #7871

merged 1 commit into from
Apr 3, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Mar 24, 2017 •
edited by bsclifton
Loading

Test Plan

  1. automated bravery panel tests should pass
  2. go to https://browserleaks.com/webrtc with fingerprinting protection enabled
  3. media device information should not be available

Description

fix #7462

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

@diracdeltas
block media device enumeration when fingerprinting protection is on
32a9959 
fix #7462

Test Plan:
1. automated bravery panel tests should pass
2. go to https://browserleaks.com/webrtc with fingerprinting protection enabled
3. media device information should not be available
@diracdeltas diracdeltas requested a review from bbondy March 24, 2017 19:15
@diracdeltas diracdeltas added this to the 0.14.1 milestone Mar 24, 2017
@diracdeltas diracdeltas self-assigned this Mar 25, 2017
@diracdeltas diracdeltas requested a review from darkdh April 3, 2017 09:59
darkdh
darkdh approved these changes Apr 3, 2017
View reviewed changes
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@diracdeltas diracdeltas merged commit e9bc323 into master Apr 3, 2017
@tsjnachos117 tsjnachos117 mentioned this pull request Apr 3, 2017
Closed
@bsclifton bsclifton deleted the fix/7462 branch May 22, 2017 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkdh darkdh darkdh approved these changes

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@diracdeltas diracdeltas

Labels
privacy QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

Removed label from multimedia devices when fingerprinting protection is on
3 participants
@diracdeltas @darkdh @bsclifton