Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Use npm shrinkwrap and travis caching #7795

Merged
merged 2 commits into from
Apr 18, 2017
Merged

Use npm shrinkwrap and travis caching #7795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfcae3c
Revert "Revert "cache travis node modules""
diracdeltas Mar 21, 2017
84f610b
Use shrinkwrap
diracdeltas Mar 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ Brave welcomes contributions via [pull requests](https://github.com/brave/browse
Fix #206
````

* If you update the npm dependencies, run `npm shrinkwrap --dev` before committing changes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is it ok to run that everytime when I commit something to keep the dependencies up to date?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luixxiul we'll want to pick and choose the times we update dependencies. Unless there is a good reason (need new version to get a feature, we're too out of date, etc) , we should stick with the version there. This is important to stabilize the codebase.

Any updates we do to libraries we use may require a small regression test to ensure the upgrade didn't break any functionality or introduce issues

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsclifton thanks!

* Run the tests by running `npm run watch-test` and `npm test` in separate terminals.
* Make sure [Flow](http://flowtype.org/) type checking passes: `npm run-script flow`. BONUS: Help us out by adding more [Flow type annotations](http://flowtype.org/blog/2015/02/20/Flow-Comments.html) to new and existing Brave code!
* When making style changes, please be sure that you are [following our style guidelines](https://github.com/brave/browser-laptop/blob/master/docs/style.md).
Expand Down
3 changes: 3 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ node_js:
- "7"
dist: trusty
sudo: required
cache:
directories:
- node_modules
before_install:
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start
Expand Down
Loading