Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Advance settings not being clickable #7660

Merged
merged 1 commit into from
Mar 12, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 12, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #7452

Auditors

@bsclifton @cezaraugusto

Test Plan

  • go to about:preferences
  • switch to Russian
  • advance settings should always be clickable (wait for a long text)

Resolves brave#7452

Auditors:
@bsclifton @cezaraugusto

Test Plan:
- go to about:preferences
- switch to Russian
- advance settings should always be clickable
@NejcZdovc NejcZdovc added this to the 0.13.6 milestone Mar 12, 2017
@NejcZdovc NejcZdovc self-assigned this Mar 12, 2017
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was only able to reproduce on Windows (which I have at 125% DPI). Change looks great! 😄

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants